reanahub / reana-client

REANA command-line client

http://reana-client.readthedocs.io/

MIT License

10 stars 45 forks source link

build: Require python >= 3.6 for install #581

Closed matthewfeickert closed 2 years ago

matthewfeickert commented 2 years ago

Add python_requires of >=3.6 to ensure that installs from PyPI coming from users on Python 2 get the last release that still had Python 2 support and not a broken (for Python 2) release with Python 3 only syntax.

matthewfeickert commented 2 years ago

@tiborsimko @mvidalgarcia @audrium this is ready for review (and needs the CI to be approved to run as this my first PR to the project). Please let me know if you have any questions or concerns.

codecov-commenter commented 2 years ago

Codecov Report

Merging #581 (85a0192) into master (875836d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   58.61%   58.61%           
=======================================
  Files          20       20           
  Lines        2433     2433           
=======================================
  Hits         1426     1426           
  Misses       1007     1007

mvidalgarcia commented 2 years ago

Should propagate this change to r-commons, r-db and pytest-reana for future releases?

matthewfeickert commented 2 years ago

Just in time as we are releasing 0.8 final today

Thanks for getting this in in time for it @tiborsimko! :)

Should propagate this change to r-commons, r-db and pytest-reana for future releases?

@mvidalgarcia yeah, that would be my recommendation. :+1:

tiborsimko commented 2 years ago

Yeah, let's propagate it elsewhere as well. However, the end users are installing only r-client, never the others... And the developers are on py38+ already...So we do have plenty of time to progressively amend r-commons et al after 0.8 is out.