search

reanahub / reana-client

REANA command-line client
http://reana-client.readthedocs.io/
MIT License
10 stars 45 forks source link

validation: add support for fully qualified image names #664

Closed mdonadoni closed 10 months ago

mdonadoni commented 10 months ago

validation: add support for fully qualified image names

Fix environment validation to correctly query the DockerHub API when the image name starts with docker.io.

Closes #663

validation: improve detection of local images

Delegate the detection of local docker images to docker, instead of manually checking the list of local images. This also handles correctly fully qualified image names.

codecov[bot] commented 10 months ago

Codecov Report

Merging #664 (4aeaa2c) into master (489c3ba) will increase coverage by 0.54%. The diff coverage is 71.42%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana-client/pull/664/graphs/tree.svg?width=650&height=150&src=pr&token=b85cSEiOhs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana-client/pull/664?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## master #664 +/- ## ========================================== + Coverage 58.08% 58.63% +0.54% ========================================== Files 24 24 Lines 2369 2369 ========================================== + Hits 1376 1389 +13 + Misses 993 980 -13 ``` | [Files Changed](https://app.codecov.io/gh/reanahub/reana-client/pull/664?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) | Coverage Δ | | |---|---|---| | [reana\_client/validation/environments.py](https://app.codecov.io/gh/reanahub/reana-client/pull/664?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfY2xpZW50L3ZhbGlkYXRpb24vZW52aXJvbm1lbnRzLnB5) | `32.50% <66.66%> (+6.13%)` | :arrow_up: | | [reana\_client/config.py](https://app.codecov.io/gh/reanahub/reana-client/pull/664?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfY2xpZW50L2NvbmZpZy5weQ==) | `100.00% <100.00%> (ø)` | |