reanahub / reana-client

REANA command-line client
http://reana-client.readthedocs.io/
MIT License
10 stars 46 forks source link

fix(status): correctly display duration of stopped workflows (#701) #701

Closed giuseppe-steduto closed 8 months ago

giuseppe-steduto commented 8 months ago

Closes #699

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (02dc830) 58.57% compared to head (b53def8) 58.62%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana-client/pull/701/graphs/tree.svg?width=650&height=150&src=pr&token=b85cSEiOhs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana-client/pull/701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## master #701 +/- ## ========================================== + Coverage 58.57% 58.62% +0.05% ========================================== Files 24 24 Lines 2390 2393 +3 ========================================== + Hits 1400 1403 +3 Misses 990 990 ``` | [Files](https://app.codecov.io/gh/reanahub/reana-client/pull/701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) | Coverage Δ | | |---|---|---| | [reana\_client/utils.py](https://app.codecov.io/gh/reanahub/reana-client/pull/701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfY2xpZW50L3V0aWxzLnB5) | `76.47% <100.00%> (+0.60%)` | :arrow_up: |
giuseppe-steduto commented 8 months ago

Note for the reviewer: I chose status as the scope of the commit because I think that the commands affected by the PR are a nice user-facing scope for changes to the client. For example, this PR fixes status, list, and in general the commands that use the --include-duration flag, I chose status as it is the one most evidently impacted. WDYT?

mdonadoni commented 8 months ago

Regarding the scope, I think fix(status) can be a good choice. WDYT @tiborsimko ? To be pedantic, I would change the commit message to display correct duration ..., just to keep the verb as the first word of the message.