search

reanahub / reana-client

REANA command-line client
http://reana-client.readthedocs.io/
MIT License
10 stars 44 forks source link

Require pulp<2.8.0 #707

Closed clelange closed 4 months ago

clelange commented 4 months ago

Here is a quick fix for #706.

Closes #706

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (783c17a) 58.62% compared to head (8fa561d) 58.62%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana-client/pull/707/graphs/tree.svg?width=650&height=150&src=pr&token=b85cSEiOhs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana-client/pull/707?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## master #707 +/- ## ======================================= Coverage 58.62% 58.62% ======================================= Files 24 24 Lines 2393 2393 ======================================= Hits 1403 1403 Misses 990 990 ```
clelange commented 4 months ago

I don't understand commitlint, please suggest a working commit message.

mdonadoni commented 4 months ago

Thanks! I will have a look now, but in any case I will move this to reana-commons (keeping your authorship, if that's ok for you)

I don't understand commitlint, please suggest a working commit message.

We have recently started appending the PR number at the end of the commit message, so that it is added to the automatically-generated changelog: ... (#707). In any case no need to fix this, as I will close this PR after opening the one in reana-commons

clelange commented 4 months ago

Thanks! I will have a look now, but in any case I will move this to reana-commons (keeping your authorship, if that's ok for you)

Sure, whatever makes sense to you!

mdonadoni commented 4 months ago

Closing as this will be fixed in https://github.com/reanahub/reana-commons/pull/444