reanahub / reana-commons

REANA common utilities and schemas
https://reana-commons.readthedocs.io/
MIT License
2 stars 38 forks source link

build(python): change extra names to comply with PEP 685 (#446) #446

Closed mdonadoni closed 6 months ago

mdonadoni commented 6 months ago

Since pip>=23.3.0, non-normalised extra names are ignored, so snakemake_reports is changed to snakemake-reports. The former name is kept for backward compatibility with older versions of pip.

Before

$ pip install --upgrade pip
$ pip install '.[snakemake-reports]' | grep WARN
WARNING: reana-commons 0.9.7 does not provide the extra 'snakemake-reports'
$ pip install '.[snakemake_reports]' | grep WARN
WARNING: reana-commons 0.9.7 does not provide the extra 'snakemake-reports'

After

$ pip install --upgrade pip
$ pip install '.[snakemake_reports]' | grep WARN
$ pip install '.[snakemake-reports]' | grep WARN
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.33%. Comparing base (b4a81d5) to head (904178f).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana-commons/pull/446/graphs/tree.svg?width=650&height=150&src=pr&token=O7K5KFXK3H&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana-commons/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## master #446 +/- ## ======================================= Coverage 36.33% 36.33% ======================================= Files 26 26 Lines 1577 1577 ======================================= Hits 573 573 Misses 1004 1004 ```