search

reanahub / reana-commons

REANA common utilities and schemas
https://reana-commons.readthedocs.io/
MIT License
2 stars 38 forks source link

perf(k8s): avoid fetching secrets multiple times (#456) #456

Closed mdonadoni closed 3 weeks ago

mdonadoni commented 4 months ago

Closes #455

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 85.57692% with 15 lines in your changes missing coverage. Please review.

Project coverage is 37.10%. Comparing base (273b72d) to head (4816f90). Report is 2 commits behind head on master.

Files Patch % Lines
reana_commons/k8s/secrets.py 85.41% 14 Missing :warning:
reana_commons/version.py 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana-commons/pull/456/graphs/tree.svg?width=650&height=150&src=pr&token=O7K5KFXK3H&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana-commons/pull/456?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## master #456 +/- ## ========================================== + Coverage 34.84% 37.10% +2.25% ========================================== Files 26 26 Lines 1650 1652 +2 ========================================== + Hits 575 613 +38 + Misses 1075 1039 -36 ``` | [Files](https://app.codecov.io/gh/reanahub/reana-commons/pull/456?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) | Coverage Δ | | |---|---|---| | [reana\_commons/k8s/kerberos.py](https://app.codecov.io/gh/reanahub/reana-commons/pull/456?src=pr&el=tree&filepath=reana_commons%2Fk8s%2Fkerberos.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfY29tbW9ucy9rOHMva2VyYmVyb3MucHk=) | `92.00% <100.00%> (+92.00%)` | :arrow_up: | | [reana\_commons/version.py](https://app.codecov.io/gh/reanahub/reana-commons/pull/456?src=pr&el=tree&filepath=reana_commons%2Fversion.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfY29tbW9ucy92ZXJzaW9uLnB5) | `0.00% <0.00%> (ø)` | | | [reana\_commons/k8s/secrets.py](https://app.codecov.io/gh/reanahub/reana-commons/pull/456?src=pr&el=tree&filepath=reana_commons%2Fk8s%2Fsecrets.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfY29tbW9ucy9rOHMvc2VjcmV0cy5weQ==) | `82.75% <85.41%> (+12.93%)` | :arrow_up: |