restart: clarify FROM and TARGET - Githubissues

reanahub / reana-demo-helloworld

REANA example - "hello world"

MIT License

3 stars 35 forks source link

restart: clarify FROM and TARGET #43

Open tiborsimko opened 4 years ago

tiborsimko commented 4 years ago

During Analysis Preservation Bootcamp, the use of the restart command with FROM and TARGET options became a bit confusing:

Does -o FROM=mystepM -o TARGET=mystepN mean that the workflow will restart including mystepM or that it will only run steps after mystepM?
IOW, are "from" and "until" terms including or excluding the listed step?

What can we do?

We can document this better.
We can muse about better words to possibly improve the meaning to avoid misunderstandings. E.g. FROM/UNTIL would be a natural duo, although "until" may have the same problem (does it include or exclude its specified boundary?).

mvidalgarcia commented 4 years ago

In my eyes, both look inclusive. For instance, in a workflow with 3 steps (s1, s2, s3):

-o FROM=s2: executes s2 and s3
-o UNTIL=s2: executes s1 and s2
-o FROM=s2 -o UNTIL=s2: executes s2

But I agree, it's a matter of document it properly.