job allocation: refactor k8s.instantiate_job into k8s.prepare_job and k8s.instantiate_job

reanahub / reana-job-controller

REANA Job Controller

http://reana-job-controller.readthedocs.io/

MIT License

2 stars 38 forks source link

job allocation: refactor k8s.instantiate_job into k8s.prepare_job and k8s.instantiate_job #33

Open lukasheinrich opened 7 years ago

lukasheinrich commented 7 years ago

For better testability separate the creation of the job spec from the actual submission

https://github.com/reanahub/reana-job-controller/blob/master/reana_job_controller/k8s.py#L56

right now it's done in one function.

diegodelemos commented 7 years ago

It is foreseen to switch from pykube to kubernetes official python client (it wasn't available back when we created this component) so a big refactor should go along with this change.