reanahub / reana-job-controller

REANA Job Controller
http://reana-job-controller.readthedocs.io/
MIT License
2 stars 38 forks source link

feat(shutdown): stop all running jobs before stopping workflow (#423) #423

Closed mdonadoni closed 9 months ago

mdonadoni commented 10 months ago

Closes https://github.com/reanahub/reana-workflow-controller/issues/546

codecov[bot] commented 10 months ago

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (8a2757e) 47.78% compared to head (99c097e) 46.46%.

:exclamation: Current head 99c097e differs from pull request most recent head 866675b. Consider uploading reports for the commit 866675b to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana-job-controller/pull/423/graphs/tree.svg?width=650&height=150&src=pr&token=0NuzA6CeSh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana-job-controller/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## master #423 +/- ## ========================================== - Coverage 47.78% 46.46% -1.32% ========================================== Files 17 17 Lines 1149 1231 +82 ========================================== + Hits 549 572 +23 - Misses 600 659 +59 ``` | [Files](https://app.codecov.io/gh/reanahub/reana-job-controller/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) | Coverage Δ | | |---|---|---| | [reana\_job\_controller/job\_manager.py](https://app.codecov.io/gh/reanahub/reana-job-controller/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfam9iX2NvbnRyb2xsZXIvam9iX21hbmFnZXIucHk=) | `89.65% <100.00%> (+0.18%)` | :arrow_up: | | [reana\_job\_controller/slurmcern\_job\_manager.py](https://app.codecov.io/gh/reanahub/reana-job-controller/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfam9iX2NvbnRyb2xsZXIvc2x1cm1jZXJuX2pvYl9tYW5hZ2VyLnB5) | `25.71% <40.00%> (-0.03%)` | :arrow_down: | | [reana\_job\_controller/htcondorcern\_job\_manager.py](https://app.codecov.io/gh/reanahub/reana-job-controller/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfam9iX2NvbnRyb2xsZXIvaHRjb25kb3JjZXJuX2pvYl9tYW5hZ2VyLnB5) | `0.00% <0.00%> (ø)` | | | [reana\_job\_controller/job\_db.py](https://app.codecov.io/gh/reanahub/reana-job-controller/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfam9iX2NvbnRyb2xsZXIvam9iX2RiLnB5) | `34.69% <21.05%> (-10.47%)` | :arrow_down: | | [reana\_job\_controller/job\_monitor.py](https://app.codecov.io/gh/reanahub/reana-job-controller/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfam9iX2NvbnRyb2xsZXIvam9iX21vbml0b3IucHk=) | `48.03% <10.00%> (+1.10%)` | :arrow_up: | | [reana\_job\_controller/kubernetes\_job\_manager.py](https://app.codecov.io/gh/reanahub/reana-job-controller/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfam9iX2NvbnRyb2xsZXIva3ViZXJuZXRlc19qb2JfbWFuYWdlci5weQ==) | `62.12% <51.06%> (-2.96%)` | :arrow_down: | | [reana\_job\_controller/rest.py](https://app.codecov.io/gh/reanahub/reana-job-controller/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfam9iX2NvbnRyb2xsZXIvcmVzdC5weQ==) | `40.76% <26.31%> (-8.24%)` | :arrow_down: |
giuseppe-steduto commented 9 months ago

I cannot really think of a better alternative

Maybe progress is a valid one?