search

reanahub / reana-ui

REANA UI frontend
http://reana-ui.rtfd.io
MIT License
4 stars 33 forks source link

global: minor UI fixes #246

Closed mvidalgarcia closed 2 years ago

mvidalgarcia commented 2 years ago

closes https://github.com/reanahub/reana-ui/issues/244 closes https://github.com/reanahub/reana-ui/issues/245 closes #249

image

audrium commented 2 years ago

PR works nicely and fixes the reported issues. But while playing with long workflow names I noticed that similar problem appears also in workflow details page: Screenshot 2022-03-17 at 16-55-23 REANA Maybe we could use something like text-overflow: ellipsis; to fix it in case the workflow name does not fit?

mvidalgarcia commented 2 years ago

One side thing I wonder is whether we shouldn't "darken" a little bit the text "Refreshed at 08:00:14 UTC" appearing on the workflow list page: currently it's too light perhaps. Darkening it would play nicely with the darker "refresh" button introduced by this PR. And we could also envisage placing a small "refresh" button just before this text, so that impatient users have a visual clue about refresh right there. (This could also allow us to decrease the polling frequency if we want in the future.)

Added in the last commit.

image

mvidalgarcia commented 2 years ago

PR works nicely and fixes the reported issues. But while playing with long workflow names I noticed that similar problem appears also in workflow details page: Screenshot 2022-03-17 at 16-55-23 REANA Maybe we could use something like text-overflow: ellipsis; to fix it in case the workflow name does not fit?

Well spotted! Should be fixed in this commit https://github.com/reanahub/reana-ui/pull/246/commits/53a9edcdb9ae75468254c34e08cd88f0b4bfa7e8