search

reanahub / reana-ui

REANA UI frontend
http://reana-ui.rtfd.io
MIT License
4 stars 33 forks source link

wf-details: make list of steps scrollable #319

Closed giuseppe-steduto closed 1 year ago

giuseppe-steduto commented 1 year ago

Closes #318

mdonadoni commented 1 year ago

It works! However I now see a very small scrolling bar:

This is due to the fact that the > div selector is selecting the wrong elements, as it selects not only div.text (i.e. the current selected item/search bar) but also div.menu (i.e. the dropdown menu). This is also why scrolling was not working in the first place, as overflow was set to hidden also for div.menu.

What do you think about this? Could you please check that this works also for you? 

> :global(.text) {
  max-width: 250px;
  @include ellipsized;
}
giuseppe-steduto commented 1 year ago

What do you think about this? Could you please check that this works also for you?

It works for me too! I didn't see the small scrolling bar (on Firefox 112.0.2, Ubuntu 22.04). Out of curiosity, which browser are you using?

mdonadoni commented 1 year ago

It works for me too! I didn't see the small scrolling bar (on Firefox 112.0.2, Ubuntu 22.04). Out of curiosity, which browser are you using?

This seems to be related to how macOS shows scroll bars. By default, "Scroll bars are shown depending on the mouse or trackpad you’re using. If your device allows gestures, scroll bars are hidden until you start scrolling. Otherwise, they’re visible" (docs). Indeed, this only happens when an external mouse is connected.

mdonadoni commented 1 year ago

minor: Can you downgrade urllib3 in a different commit, so that it's clear it's not related to making the list scrollable? Could you also update CHANGES.rst?