search

reanahub / reana-ui

REANA UI frontend
http://reana-ui.rtfd.io
MIT License
4 stars 33 forks source link

ui: add item to actions popup to allow stopping workflow #332

Closed mdonadoni closed 1 year ago

mdonadoni commented 1 year ago

Closes reanahub/reana#724

mdonadoni commented 1 year ago

Comment regarding this PR: the changes in this PR are similar to what is done to implement the Delete workflow action, so there is a bit of duplicated code. I think we can keep this for the time being, and improve this later when we will add more actions to the UI. What do you think?

mdonadoni commented 1 year ago

Another note, not directly related to this PR, but rather to the way in which stopped workflows are displayed. The timer that usually says for how long a workflow has been running doesn't stop when the workflow is stopped. This results in the "stopped after X minutes Y seconds" phrase with X and Y constantly increasing as time passes. Also, opening the "job logs" tab of a stopped workflow, the different jobs are still in running status, with the timer that is still ongoing and constantly increasing. This behavior persists even after the stopped workflow is deleted.

Could you please open an issue? Thanks!