refactor: workflow restart/rerun using the same workspace

reanahub / reana-workflow-controller

REANA Workflow Controller

http://reana-workflow-controller.readthedocs.io/

MIT License

2 stars 38 forks source link

refactor: workflow restart/rerun using the same workspace #289

Closed roksys closed 4 years ago

roksys commented 4 years ago

Refactor workflow restart/rerun using the same workspace as a new run, which will help for future accounting.
Save workspace path in workflow model, will help for future EOS workspaces.

diegodelemos commented 4 years ago

LGTM code-wise, just testing it out remaining

tiborsimko commented 4 years ago

Remains to be done:

(1) separate restart command so that workflow spec changes can be taken into account:

$ reana-client restart -f reana.yaml -w myanalysis.42

(2) consider whether to (2a) keep run_number as DB float (relying on casting) or whether to (2b) keep run_number, rerun_number as DB ints (relying on composing/decomposing abstract properties with getter/setter).

tiborsimko commented 4 years ago

(3) Warn user that workflow does not correspond to asked-for rerun number, for example if there were thirtheen reruns of myanalysis.42, and if a user ask for some intermediate one:

$ reana-client ls -w myanalysis.42.7
[WARNING] Showing latest workspace `myanalysis.42` corresponding to the latest rerun number `myanalysis.42.13`:
...