reanahub / reana-workflow-controller

REANA Workflow Controller
http://reana-workflow-controller.readthedocs.io/
MIT License
2 stars 38 forks source link

refactor(secrets): adapt to reana-commons secret-handling changes (#583) #583

Closed mdonadoni closed 2 months ago

mdonadoni commented 6 months ago

Closes reanahub/reana-commons#455

mdonadoni commented 6 months ago

TODO:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.13%. Comparing base (fb9923c) to head (d9512fb). Report is 1 commits behind head on master.

Files Patch % Lines
reana_workflow_controller/rest/utils.py 16.66% 5 Missing :warning:
reana_workflow_controller/consumer.py 90.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana-workflow-controller/pull/583/graphs/tree.svg?width=650&height=150&src=pr&token=SC0cf8SzMF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana-workflow-controller/pull/583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## master #583 +/- ## ========================================== + Coverage 74.28% 75.13% +0.85% ========================================== Files 15 15 Lines 1466 1476 +10 ========================================== + Hits 1089 1109 +20 + Misses 377 367 -10 ``` | [Files](https://app.codecov.io/gh/reanahub/reana-workflow-controller/pull/583?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) | Coverage Δ | | |---|---|---| | [reana\_workflow\_controller/k8s.py](https://app.codecov.io/gh/reanahub/reana-workflow-controller/pull/583?src=pr&el=tree&filepath=reana_workflow_controller%2Fk8s.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfd29ya2Zsb3dfY29udHJvbGxlci9rOHMucHk=) | `88.97% <100.00%> (ø)` | | | [reana\_workflow\_controller/workflow\_run\_manager.py](https://app.codecov.io/gh/reanahub/reana-workflow-controller/pull/583?src=pr&el=tree&filepath=reana_workflow_controller%2Fworkflow_run_manager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfd29ya2Zsb3dfY29udHJvbGxlci93b3JrZmxvd19ydW5fbWFuYWdlci5weQ==) | `81.27% <100.00%> (+0.08%)` | :arrow_up: | | [reana\_workflow\_controller/consumer.py](https://app.codecov.io/gh/reanahub/reana-workflow-controller/pull/583?src=pr&el=tree&filepath=reana_workflow_controller%2Fconsumer.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfd29ya2Zsb3dfY29udHJvbGxlci9jb25zdW1lci5weQ==) | `55.84% <90.00%> (+10.57%)` | :arrow_up: | | [reana\_workflow\_controller/rest/utils.py](https://app.codecov.io/gh/reanahub/reana-workflow-controller/pull/583?src=pr&el=tree&filepath=reana_workflow_controller%2Frest%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfd29ya2Zsb3dfY29udHJvbGxlci9yZXN0L3V0aWxzLnB5) | `81.06% <16.66%> (-0.73%)` | :arrow_down: |