search

reanahub / reana-workflow-engine-cwl

REANA Workflow Engine CWL
http://reana-workflow-engine-cwl.readthedocs.io/
MIT License
5 stars 37 forks source link

models: modify workspace_path to store full path #193

Closed marcdiazsan closed 3 years ago

marcdiazsan commented 3 years ago

Delete the dependency on SHARED_VOLUME_PATH by storing the full path inside the database, for serial, yadage and cwl engines.

Closes reanahub/reana-db#94

codecov-commenter commented 3 years ago

Codecov Report

Merging #193 (5f15fb4) into master (3ccc628) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   24.77%   24.81%   +0.04%     
==========================================
  Files          10       10              
  Lines         549      548       -1     
==========================================
  Hits          136      136              
+ Misses        413      412       -1
Impacted Files Coverage Δ
reana_workflow_engine_cwl/main.py 27.16% <100.00%> (+0.33%) :arrow_up:
audrium commented 3 years ago

Looks good! same comment as here

audrium commented 3 years ago

Looks good, I think only commit squash is missing here