search

reanahub / reana-workflow-engine-serial

REANA Workflow Engine Serial
http://reana-workflow-engine-serial.readthedocs.org
MIT License
0 stars 33 forks source link

logs: proper workflow status reporting #102

Closed tiborsimko closed 4 years ago

tiborsimko commented 4 years ago

Current behaviour

Seen a case where the workflow failed:

$ reana-client status -w htc
NAME   RUN_NUMBER   CREATED               STARTED               ENDED                 STATUS   PROGRESS
htc    2            2020-02-20T13:55:38   2020-02-20T13:55:40   2020-02-20T13:57:18   failed   0/2

But the logs said:

$ reana-client logs -w htc
==> Workflow engine logs
2020-02-20 13:57:18,376 | root | MainThread | INFO | Workflow 8b9c4b3c-5ac9-40ed-8c3a-493e9617a0bc finished. Files available at /var/reana/users/00000000-0000-0000-0000-000000000000/workflows/8b9c4b3c-5ac9-40ed-8c3a-493e9617a0bc.

Note that status is "failed" but the logs say "finished" which is the word we use for successfully terminated workflows.

Expected behaviour

If a workflow fails, the workflow engine should say so in the logs.

roksys commented 4 years ago

Addressed by https://github.com/reanahub/reana-workflow-engine-serial/pull/101