reanahub / reana-workflow-engine-snakemake

REANA Workflow Engine Snakemake
MIT License
0 stars 22 forks source link

incorrect values in custom resources fail but do not generate workflow logs #35

Closed VMois closed 2 years ago

VMois commented 2 years ago

When custom resources like kubernetes_memory_limit or kubernetes_job_timeout are specified with an incorrect type, the workflow fails, but reana-client logs do not show any logs at all.

The issue was discovered for CWL in https://github.com/reanahub/reana-workflow-engine-cwl/pull/214#pullrequestreview-835171935 but, after more checks (here), I discovered it also affects Snakemake.

To reproduce

Go to helloworld example. Set kubernetes_memory_limit to something like:

rule helloworld:
...
    resources:
        kubernetes_memory_limit=1000. # or "500MB"
...

The correct value is a string like "1000MiB" but we specified integer.

  1. Run workflow using reana-client run -w snake-no-logs -f reana-snakemake.yaml

  2. Check logs using reana-client logs -w snake-no-logs. It will be empty.

  3. Check workflow logs using `kubectl logs workflow engine and you will some errors.

VMois commented 2 years ago

This issue is most probably caused by job-status-consumer