reanahub / reana-workflow-engine-snakemake

REANA Workflow Engine Snakemake
MIT License
0 stars 22 forks source link

fix executor for the rootfit example #5

Closed tiborsimko closed 3 years ago

tiborsimko commented 3 years ago

The basic executor introduced in #3 works well for r-d-helloworld and r-d-worldpopulation, but I'm getting troubles for r-d-r-roofit:

$ reana-client logs -w root6-roofit-snakemake-kubernetes
...
 0x0000555cd2000a5a in _start + 0x2a from /usr/local/bin/root.exe
Error in <HandleInterpreterException>: Trying to dereference null pointer or trying to call routine taking non-null arguments.
Execution of your code was aborted.
In file included from input_line_8:1:
/var/reana/users/00000000-0000-0000-0000-000000000000/workflows/3858f9d1-92ca-4070-942e-fb1ab0d25215/code/fitdata.C:24:19: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
  RooRealVar* x = w->var("x") ;
                  ^

Error

It seems that "fitdata" is attempted to run before "gendata":

$ reana-client logs -w root6-roofit-snakemake-kubernetes | grep Step
==> Step: fitdata

Note that a standalone Snakemake execution, i.e. outside of the REANA platform, works well, so it would seem that Snakefile is well defined WRT step execution order?

To be checked and fixed.

(stems from https://github.com/reanahub/reana-workflow-engine-snakemake/pull/3#pullrequestreview-725117383)