reanahub / reana-workflow-engine-snakemake

REANA Workflow Engine Snakemake
MIT License
0 stars 21 forks source link

executor: fix tracking of active jobs #60

Closed mdonadoni closed 1 year ago

mdonadoni commented 1 year ago

Fix an issue where workflows would be stuck waiting for already-finished jobs. This happened because the list of active jobs was incorrectly overwritten instead of being extended, causing the executor to lose track of some of them.

Closes #59

codecov-commenter commented 1 year ago

Codecov Report

Merging #60 (7b57364) into master (ff43fba) will not change coverage. The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana-workflow-engine-snakemake/pull/60/graphs/tree.svg?width=650&height=150&src=pr&token=T60GN05T4Q&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana-workflow-engine-snakemake/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## master #60 +/- ## ====================================== Coverage 3.84% 3.84% ====================================== Files 6 6 Lines 182 182 ====================================== Hits 7 7 Misses 175 175 ``` | [Impacted Files](https://app.codecov.io/gh/reanahub/reana-workflow-engine-snakemake/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) | Coverage Δ | | |---|---|---| | [reana\_workflow\_engine\_snakemake/executor.py](https://app.codecov.io/gh/reanahub/reana-workflow-engine-snakemake/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmFfd29ya2Zsb3dfZW5naW5lX3NuYWtlbWFrZS9leGVjdXRvci5weQ==) | `0.00% <0.00%> (ø)` | |