search

reanahub / reana-workflow-engine-snakemake

REANA Workflow Engine Snakemake
MIT License
0 stars 21 forks source link

docker: integrate ImageMagick v6 with v7 wrapper for report thumbnails #72

Closed giuseppe-steduto closed 7 months ago

giuseppe-steduto commented 7 months ago

ImageMagick is needed by Snakemake to generate the thumbnails for the files in the HTML reports. Snakemake uses ImageMagick v7 (called via magick convert, but on Ubuntu 20.04 only ImageMagick v6 (called via convert) is available, so this commit adds a script to mimic ImageMagick v7 using the available version.

How to test: Run a snakemake workflow in which the Snakefile contains report detail about the files produced by the workflow (details on how to do it on the Snakemake documentation) and check the difference in the engine logs and generated report with and without these changes to the image.

A Snakemake example that uses the roofit demo is available here: https://github.com/giuseppe-steduto/reana-demo-root6-roofit/tree/snakemake-improve-report

codecov[bot] commented 7 months ago

Codecov Report

Merging #72 (4faf779) into master (cad5f8e) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana-workflow-engine-snakemake/pull/72/graphs/tree.svg?width=650&height=150&src=pr&token=T60GN05T4Q&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana-workflow-engine-snakemake/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## master #72 +/- ## ====================================== Coverage 3.84% 3.84% ====================================== Files 6 6 Lines 182 182 ====================================== Hits 7 7 Misses 175 175 ```