search

reanahub / reana

REANA: Reusable research data analysis platform
https://docs.reana.io
MIT License
127 stars 54 forks source link

release: Helm release missing from index.yaml #314

Closed diegodelemos closed 4 years ago

diegodelemos commented 4 years ago

The release 0.7.0-dev20200520 is not present in https://reanahub.github.io/reana/index.yaml however we can find it in the repository releases https://github.com/reanahub/reana/releases.

This needs to be fixed as the Helm executable relies on index.yaml to fetch the latest release.

diegodelemos commented 4 years ago

This specific case has been addressed in https://github.com/reanahub/reana/pull/316 by releasing manually. The problem is that we are using on tag push event and we were pushing the tags reana-X.Y.Z | reana-X.Y.Z-devYYYYMMDD which is what Chart Releaser relies on, so:

  1. We push the tag
  2. The GitHub action runs
  3. Chart Releaser detects no changes as the tag is already created

Some real solutions: a. Trigger manually b. Trigger on merge to master and changes to helm/reana (this is what we used to have, see https://github.com/reanahub/reana/commit/9a2a31397fa9de2920366cf9eca2fecbddd9fea2#diff-501e5be0ca0beb4b7c14eef6eaff1edc) c. Push two tags: one tag to trigger the GitHub actions, second tag with the format previously stated which will be created by Chart Releaser d. Others? Here the list of possible events that can trigger GitHub Actions workflows

I would go for (b) although that would mean we spend GitHub actions quota for nothing (what would happen is the result described in previously listed point 3.)

P.S.: It wasn't straight forward to come to this conclusion as GitHub actions, contrary to Travis CI or REANA, do not have a notion of history of previous workflow runs for a single workflow/commit/pull request/branch, one can see the history of different workflow/commit/pull request/branch.

mvidalgarcia commented 4 years ago

I would also go for (b). It might seem that we're triggering too many releases but I think it's because we're in a helm early stage. I want to think that in the future our charts will be more stable and won't trigger so many GitHub Actions workflows.