reanahub / reana

REANA: Reusable research data analysis platform
https://docs.reana.io
MIT License
127 stars 54 forks source link

make: release build is not aware of BUILD_ARGUMENTS #342

Closed tiborsimko closed 4 years ago

tiborsimko commented 4 years ago

Setting BUILD_ARGUMENTS works for developer-oriented builds, such as:

$ DEMO=r-d-r-roofit EXCLUDE_COMPONENTS=r-ui,r-m-broker BUILD_ARGUMENTS="COMPUTE_BACKENDS=htcondorcern,slurmcern,kubernetes" make ci

However it does not work for release builds, so images such as reanahub/reana-job-controller-htcondorcern-slurmcern:0.6.0-31-g35c4fc8 are not having Condor installed.

Three solutions:

tiborsimko commented 4 years ago

The build arguments have been moved to shell scripts. What remains to be done is the naming of the docker image. This is related to issues #370 and #363. I'll add a comment there and close the issue here.