cli: shared modules are not upgraded correctly

reanahub / reana

REANA: Reusable research data analysis platform

https://docs.reana.io

MIT License

127 stars 54 forks source link

cli: shared modules are not upgraded correctly #412

Closed audrium closed 4 years ago

audrium commented 4 years ago

Running reana-dev git-upgrade-shared-modules -c r-server requirements (in setup.py) were upgraded to the following:

- "reana-db>=0.7.0a6,<0.8.0",
+ "reana-db>=0.8.0a1,<0.8.0",

while the correct output would be: "reana-db>=0.8.0a1,<0.9.0",

tiborsimko commented 4 years ago

This is connected to the fact that master is now being used for both 0.7.0 work and 0.8.0 work.

We need to start maint-0.7 branches rapidly so that we can cleanly separate these works. Then we'll be able to amend setup requirements everywhere.

Note also #413 that is related and that will come very handy for these situations.

tiborsimko commented 4 years ago

maint-0.7 created everywhere in CLIENT and CLUSTER repositories, and there are many PRs to update master lower pins, so this will be fixed soon.

tiborsimko commented 4 years ago

OK, installation problem fixed... Remains to amend git-upgrade-shared-modules command to properly upgrade top boundary, which was the core of the issue :wink: