reana-dev helm-upgrade-components should also update prefetch-images script

reanahub / reana

REANA: Reusable research data analysis platform

https://docs.reana.io

MIT License

127 stars 54 forks source link

reana-dev helm-upgrade-components should also update prefetch-images script #515

Closed tiborsimko closed 3 years ago

tiborsimko commented 3 years ago

reana-dev helm-upgrade-components currently updates helm/reana/values.yaml file. For example, it replaces images:

     docs_url: http://docs.reana.io
     forum_url: https://forum.reana.io
     imagePullPolicy: IfNotPresent
-    image: reanahub/reana-ui:0.8.0-alpha.1
+    image: reanahub/reana-ui:0.8.0-alpha.2

It should also update scripts/prefetch-images.sh where these images are pre-fetched.

VMois commented 3 years ago

I can see that prefetch-images.sh is only used on one page, in one part in docs.reana.io. Do we really need it? I believe, helm (or kind) can fetch those images without a problem.

If it is really that necessary to maintain this file, I would prefer to fetch values from values.yml and generate a new bash from this. This will ensure better consistency.

mvidalgarcia commented 3 years ago

It's also referenced in www.reana.io as part of the Get started section.

Check this commit and the issue it closes.