reanahub / reana

REANA: Reusable research data analysis platform
https://docs.reana.io
MIT License
123 stars 54 forks source link

Add compute4punch compute_backend #780

Closed giffels closed 2 months ago

giffels commented 6 months ago

This pull request adds the new compute4punch compute backend to the list of available compute backends. The compute4punch compute backend is currently implemented in https://github.com/reanahub/reana-job-controller/pull/430.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 18.15%. Comparing base (822c386) to head (89bce51). Report is 1 commits behind head on maint-0.9.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana/pull/780/graphs/tree.svg?width=650&height=150&src=pr&token=NmV0ZCmqfN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana/pull/780?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## maint-0.9 #780 +/- ## ========================================== Coverage 18.15% 18.15% ========================================== Files 26 26 Lines 2478 2478 ========================================== Hits 450 450 Misses 2028 2028 ``` | [Files](https://app.codecov.io/gh/reanahub/reana/pull/780?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) | Coverage Δ | | |---|---|---| | [reana/config.py](https://app.codecov.io/gh/reanahub/reana/pull/780?src=pr&el=tree&filepath=reana%2Fconfig.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmEvY29uZmlnLnB5) | `100.00% <100.00%> (ø)` | | | [reana/reana\_dev/cluster.py](https://app.codecov.io/gh/reanahub/reana/pull/780?src=pr&el=tree&filepath=reana%2Freana_dev%2Fcluster.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmEvcmVhbmFfZGV2L2NsdXN0ZXIucHk=) | `0.00% <ø> (ø)` | |
arm2arm commented 3 months ago

Hi @tiborsimko , what is the situation with this integration, I have a branch with slurm integration as well, where to start merging them ?

tiborsimko commented 2 months ago

Hi @tiborsimko , what is the situation with this integration, I have a branch with slurm integration as well, where to start merging them ?

Hi @arm2arm The integration was delayed due to some illnesses and absences on our end... We are getting to it this week and the next.

BTW some of the remarks made by @mdonadoni in @giffels's pull requests were still not fully closed and may be important, such as a possible code injection? Would you be able to look into them before the integration?