reanahub / reana

REANA: Reusable research data analysis platform
https://docs.reana.io
MIT License
123 stars 54 forks source link

feat(reana_dev): customize kind image version (#811) #811

Open jlemesh opened 1 month ago

jlemesh commented 1 month ago

Similar issue happened to me using reana-dev tool with fresh kind install. kind pulls the latest image version, but the version does not match kubeVersion in Helm chart, which causes error on Helm chart deployment.

Though Helm chart is now upgraded and accepts newest image version, at some point in time discrepancy will happen again. kindest/node image version can just be pinned (should be updated together with Helm chart) and can be allowed to customize as a CLI option.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 19.20%. Comparing base (a288636) to head (d510990).

Files with missing lines Patch % Lines
reana/reana_dev/cluster.py 0.00% 6 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/reanahub/reana/pull/811/graphs/tree.svg?width=650&height=150&src=pr&token=NmV0ZCmqfN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub)](https://app.codecov.io/gh/reanahub/reana/pull/811?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) ```diff @@ Coverage Diff @@ ## master #811 +/- ## ========================================== - Coverage 19.22% 19.20% -0.03% ========================================== Files 26 26 Lines 2512 2515 +3 ========================================== Hits 483 483 - Misses 2029 2032 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/reanahub/reana/pull/811?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub) | Coverage Δ | | |---|---|---| | [reana/reana\_dev/cluster.py](https://app.codecov.io/gh/reanahub/reana/pull/811?src=pr&el=tree&filepath=reana%2Freana_dev%2Fcluster.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reanahub#diff-cmVhbmEvcmVhbmFfZGV2L2NsdXN0ZXIucHk=) | `0.00% <0.00%> (ø)` | |