reanimate / reanimate-svg

BSD 3-Clause "New" or "Revised" License
4 stars 8 forks source link

Add Merge and MergeNode filter effects #10

Closed joseedil closed 4 years ago

joseedil commented 4 years ago

MergeNode has no Filter Attributes, which potentially breaks the FilterElement HasFilterAttributes instance, but seems to be working correctly.

The unparseFE function has a potential bug: it allows feMergeNode elements to appear outside of feMerge elements.

lemmih commented 4 years ago

We can't capture all SVG semantics with the type system so I think it's okay that feMergeNode can appear outside of feMerge elements.