search

reanimate / reanimate-svg

BSD 3-Clause "New" or "Revised" License
4 stars 8 forks source link

deriving via Last #26

Closed georgefst closed 3 years ago

georgefst commented 3 years ago

The persistent use of Last adds a fair bit of noise to using this library, both when transforming attributes, and when looking at document ASTs (which are otherwise very readable with pretty-simple).

In recent GHC versions, we could get the same behaviour by using DerivingVia for the Monoid instances, without needing to wrap everything.

This would of course be a breaking change, and I'd understand if you don't think it's worth it.

lemmih commented 3 years ago

I think it would be worth it.

georgefst commented 3 years ago

Great. I'll get to work.