search

reanimate / reanimate-svg

BSD 3-Clause "New" or "Revised" License
4 stars 8 forks source link

Remove use of 'Last' #27

Closed georgefst closed 3 years ago

georgefst commented 3 years ago

Closes #26.

Slight change of plan. Seeing as the Semigroup instance of Last a is only made use of in defining Semigroup DrawAttributes (which is necessarily explicit, not derived), it's simpler to just define a simpler local helper function there (chooseLast), rather than even involving typeclasses.

PS. turns out Data.Monoid.Last is informally marked as deprecated anyway

lemmih commented 3 years ago

Thanks! This is so much better.