search

reaper-oss / sws

The SWS extension is a collection of features that seamlessly integrate into REAPER, the Digital Audio Workstation (DAW) software by Cockos, Inc
https://www.sws-extension.org/
MIT License
448 stars 85 forks source link

a quick report of padre lfo and envelope editor bugs. #123

Open Jeff0S opened 10 years ago

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on April 18, 2010 19:55:18

Will do proper ones when I have more details and time to test more but for now below are some quick notes I took (sorry it's not by the rules but I

thought it's better to report them rough for now)

-did a 1/2 sine with 50% offset (which worked) then changed it to -50 offset but kept strength on 100% and it crashed (my tempo was 155.677, could that be a problem being none integer?) not easily reproducible though

-undos not working very well (missing steps but hard to reprduce)

-envelope processor not including the first or last point when using "amplify" (I think I know why you've done this though) :)

-Why not combine the two Padre editor windows (and Fingers groove menu etc) into an actually window we can access from the reaper view menu like most other sws ones? :)

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=123

Jeff0S commented 10 years ago

From Atrabili...@gmail.com on April 18, 2010 23:00:01

Jeff0S commented 10 years ago

From jeffos...@gmail.com on September 23, 2010 03:49:11

Assigned to Padre (so that you receive a notif, Padre).

About Undos instability: some LFO's code uses things like Undo_BeginBlock/Undo_EndBlock blocks (rather than Undo_OnStateChangeEx) but these "blocks" may be broken with "return" statements. I know this could lead to unpredictable behavior.. Padre, let me know if you can't check that, I'll have a look (later).

Owner: AtrabilisSunrise

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on September 23, 2010 05:06:32

Thanks Jeffos (and Padre) ;)

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on October 17, 2010 08:48:10

Hi Jeffos, did you get time to look at the undo problem with the LFO gen?

I was just retesting it now but got the below crash.. any ideas? :)

Just got this crash whilst using the lfo generator after using undo then trying something else (without closing the lfo window)

Problem signature: Problem Event Name: APPCRASH Application Name: reaper.exe Application Version: 3.7.1.6 Application Timestamp: 4cba4fab Fault Module Name: StackHash_2228 Fault Module Version: 6.1.7600.16385 Fault Module Timestamp: 4a5bdb3b Exception Code: c0000374 Exception Offset: 000cdcbb OS Version: 6.1.7600.2.0.0.256.48 Locale ID: 2057 Additional Information 1: 2228 Additional Information 2: 22280a3b27eb14db473438a74409d3d1 Additional Information 3: 3c02 Additional Information 4: 3c028baf9022bba4108161d9d9162e5b

Jeff0S commented 10 years ago

From jeffos...@gmail.com on October 19, 2010 13:34:19

Undos should now be safer ( r231 ).

Status: Started

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on October 19, 2010 13:37:58

cool will try it.. thanks

Jeff0S commented 10 years ago

From swstim on October 19, 2010 13:46:35

mbn, this is coming in build #3.

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on October 19, 2010 13:48:51

roger that :) will wait..

Jeff0S commented 10 years ago

From fingersmcgarnickle on January 24, 2011 15:26:06

Adding CC LFOs when there are tempo markers near the item causes bad things to happen. Probably should change to chunk editing rather than using MIDI_events as they don't exhibit this behaviour.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 07, 2011 03:13:21

also (note for later), CC LFO cannot work with slip edited MIDI items.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on August 12, 2011 07:04:47

undos don't crash anymore, but it seems another issue still there : http://forum.cockos.com/showthread.php?t=85431 (waiting for reliable repro..)