reaper-oss / sws

The SWS extension is a collection of features that seamlessly integrate into REAPER, the Digital Audio Workstation (DAW) software by Cockos, Inc
https://www.sws-extension.org/
MIT License
456 stars 86 forks source link

SWS/S&M beta (build #6): issues/regressions #175

Closed Jeff0S closed 10 years ago

Jeff0S commented 10 years ago

From jeffos...@gmail.com on August 21, 2010 18:47:54

This is a "fake" issue I create so that people can report issues/regression about the upcoming beta (build #1), if any..

Please, answer this questions: What steps will reproduce the problem? What is the expected output? What do you see instead? What Reaper version #? Thanks!

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=175

Jeff0S commented 10 years ago

From jeffos...@gmail.com on August 25, 2010 12:04:03

hey, no prob gofer, that's fast not late! ok, just before forgetting that report (yeah.. as you know I hate crashes ;-): a last question, do you remember the faulty module (reaper_sws.dll? ntdll.dll? reaper.exe?), I have a doubt the .ini could be the culprit, I just tried to corrupt mine and to simulate color => color+icon upgrade without "crash" success, again. thanks for the details.

on a sidenote: gofer, I'm close in "delaying" MIDI CC only actions, I implemented something very close not to stuck REAPER with my new "Apply live config n (MIDI CC only)" => should come at some point ;-)

Jeff0S commented 10 years ago

From brk...@gmail.com on August 25, 2010 14:19:38

hi Jeffos, been trying out the live config, and managed to convert notes to individual ccs, and was testing with some footbuttons - on a side note i think on receiving config 2 cc, the gui didn't change to config 2 and the effect chain was not loaded although the * was there, if you manually switched config it worked, so i stayed in config 1 for my tests. anyway when i switched to mixer view and got rid of live config gui, reaper crashed, blaming reapersws.dll - happens all the time with this little test project - which i have included. opening it offline pointed to reacontrol midi being the problem as that was using the first slider assigned to live config 1 via a virtual midi port.

? thanks! hope its of some help.

Attachment: footbuttonscontrol-liveconfig.RPP

Jeff0S commented 10 years ago

From fr.gerl...@web.de on August 26, 2010 00:34:48

It crashed in module reaper.exe, Offset:00367147. I would want to give you the corrupt .ini, but when I reopen Reaper with that .ini after the crash (need to reboot the PC, because Reaper.exe hangs and can't be killed even by process explorer) it doesn't seem to be the same as the moment it crashed. Preference settings have changed, Default theme is used, VST folder is not defined, Auto color/icon entries have changed and more stuff like that. But the most telling: It won't show that crash anymore, even if I try and redo the settings that crashed it beforehand. So during troubleshooting I lost the initial faulty .ini file. But at the same time it leads me to think that the fault is a combination of entries. Reaper.ini seems a very moving target...

Sidenote on the sidenote: Hey that smells like something big :D.

Jeff0S commented 10 years ago

From hooey...@gmail.com on August 26, 2010 01:37:14

"@susan: thanks! hey that's a fat font! (what is the theme you're using? I'd like to test some other things with it..) but this should be ok in this build #3 (?)"

Yes, it looks fine in build #3, thanks. I'm pretty sure I tried this with the default theme too when I first saw the problem and that made no difference. That's why I figured it was a font issue, but I don't know which font element in the Theme Editor it's using. I thought maybe it was the Track Name, but changing that had no effect.

-Susan

Jeff0S commented 10 years ago

From jeffos...@gmail.com on August 26, 2010 04:19:35

@brkolb: crash confirmed, thanks for the attached RPP. This one is HOT and make the Live Configs almost unusable (regression introduced in beta #3, I didn't test enough..) => fixed in beta #4, just uploaded

brkolb, for the rest, no sorry, the view won't switch to the triggered config because CC actions can occur on the 8 configs simultaneously => that's why I tagged the CC values with "*" so that the info is available even if this config isn't the displayed one and when the triggered config matches the displayed one, the related CC value gets selected (hum.. I re-read.. seems complicated, I hope that's clear :)

@gofer: thanks! what is "cool" is that the faulty module is reaper.exe.. so for the moment, let's say you found something strange but not in the extension..

@susann: thanks!

Summary: SWS/S&M beta (build #4): issues/regressions

Jeff0S commented 10 years ago

From fr.gerl...@web.de on August 26, 2010 04:51:16

Some oddness in the logic of Autocolor/icon (using beta3, but I guess it's not new since icons are in):

Result #1: track 3 loses it's icon, although it is not at all involved.

Result #2: track 2 loses it's icon.

expected #1: track 3 keeps it's icon, as it is not a children of any track or changed it's state in any way.

expected #2: track 2 keeps it's icon. I can see why that is (no icon defined for children in autocolor), but still I'd prefer it would keep it.

Jeff0S commented 10 years ago

From theartfu...@googlemail.com on August 26, 2010 07:14:59

Hi,

That's a shame about the presets, best of luck with getting it sorted.

I have another Live Configs bug for you. The Activate Action is performed when a row is activated or deactivated. The Deactivate Action is never performed.

Cheers!

Jeff0S commented 10 years ago

From jeffos...@gmail.com on August 26, 2010 10:02:13

@gofer!!! you're good you know! Result #2: yes, Tim pointed it out already, it's a known limitation.. If you set an icon "manually" (using REAPER's menu) they're gonna be overrided by the auto-icon rules. For auto colors, I thought Tim managed that (so that "manual" colors don't get overrided) but I can see that same limitation in official build v1.7.3 #3: set a manual color to track 2 then drag it as a child of track1 => your "manual" color is overrided by the one you've set in the "(children)" rule. The same goes when track renaming matching an existing rule.. So this is a limitation in the official release too (perhaps even a bug as I know Tim wanted to manage that case.. not a biggie tho, noted, we'll talk about it when he'll be less busy ;-)

Result #1: track 3 loses it's icon I don't confirm that one here. There's something else: can you post your REAPER.ini and RPP (before the drag) ?

@theartfulregster: pffff... yes, confirmed.. I broke that in an earlier beta build.. fixed. theartfulregster!? what's your nickname on REAPER's main forum?

Jeff0S commented 10 years ago

From jeffos...@gmail.com on August 26, 2010 10:04:55

ok!! "cap'tain"

Jeff0S commented 10 years ago

From theartfu...@googlemail.com on August 26, 2010 14:09:40

Aye aye! :)

Jeff0S commented 10 years ago

From fr.gerl...@web.de on August 27, 2010 01:00:09

No, I'm not good at all, I guess. This is becoming really embarrassing! Not only I left out that I need a folder with at least one child below track 3 in my receipt, but I also missed checking whether it happens with a fresh reaper.ini. And I should have double-checked after all my trouble with hosed .ini files before this. To say it clear: it doesn't happen with a fresh .ini. So much about me and concise bug reports... dang!

For some reason I manage to constantly break something in Reaper.ini while testing it seems. Can it be that just leaving that file open in notepad (not changing or saving, just monitoring) can stir it up somehow? I don't think it's of much use for you to invest further time into this until someone else reports the same, but just in case I attach that hosed .ini file and a project I tried to dumb down to the minimum necessary to trigger the fault (only with that faulty .ini).

Have fun with it if you like, but I propose leaving it on the back burner until maybe another similar report comes in.

Attachment: autoiconmagic.RPP gofers_hosed_REAPER.ini

Jeff0S commented 10 years ago

From jeffos...@gmail.com on August 27, 2010 05:24:59

Gofer, thanks A LOT for the RPP, easier/faster fix for me! => I now confirm the "Result #1" but, yes, another folder was indeed needed below track 3 => thanks to this project, I've also seen a possible issue with icon removal (this was working but this wasn't safe). I'm almost sure I explains that strange crash you were the only one to see. So got it! YEAH!!!

Beta #5 just uploaded with those 2 fixes + Live config activate/deactivate actions/macros fix (this one fix included in the x64 beta #4).

Note: the "limitations" discussed above that are also present in the official release still there. I've seen another one: 3 tracks, rule with (children) color, drag track 2 as child of track 1 (OK: get colored according to the rule), re-drag track 2 so that it's a normal track again (remains colored with (children) rule: KO?). => the same limitations will apply with auto-icon in this betas..

Summary: SWS/S&M beta (build #5): issues/regressions

Jeff0S commented 10 years ago

From jeffos...@gmail.com on August 27, 2010 05:31:54

I want to add that my english doesn't suck THAT hard ^^^ (going to fast + can't edit posts here ;-)

Jeff0S commented 10 years ago

From theartfu...@googlemail.com on August 27, 2010 07:28:49

Thanks Jeffos, this is working well.... apart from one little thing.... sorry! :)

If a track is selected that isn't in any Live Config rows before activating a Live Config row, that track is not de-selected. The Activate and Deactivate actions are performed on all selected tracks instead of just the one in the Live Config row.

Cheers.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on August 28, 2010 03:28:25

theartfulregster, this is voluntary: it'll be bad to change unrelated track selections IMO. Example: on the contrary, some users (me ;-) may want activate and deactivate actions to work on other tracks (than the configured ones), or even use macros that change those selections.. so changing them automatically would be bad IMO.

To manage that: either ensure your "Live RPP" is saved without track selection, or use a CC value conf that reinit everything (including "clears all track selection").

Jeff0S commented 10 years ago

From theartfu...@googlemail.com on August 28, 2010 06:57:43

Okay, thanks the the reply Jeffos. I can see where you are coming from, I'll just make some Custom Actions with the starting actions being ones to unselect all tracks and select only the one I want.

This is a very, very interesting extension. Oooh, I feel a JS plugin coming on!!

:)

Jeff0S commented 10 years ago

From mercadon...@gmail.com on August 30, 2010 18:32:52

Hi Jeffos,

I just noticed that "Hide/Show take volume/pan/mute envelope" actions are really slow and they even freeze REAPER for a couple of minutes if you run it on a lot of items at the same time.

Beta #5, build x64.

Cheers

Jeff0S commented 10 years ago

From jeffos...@gmail.com on August 31, 2010 07:18:45

funny, I have already boosted them: will be available in the next beta..

Jeff0S commented 10 years ago

From theartfu...@googlemail.com on August 31, 2010 15:52:59

Hi, sorry to annoy you about Live Configs but I have a little feature request I would like to share with you.

I am assuming (maybe wrongly) that the delay in switching between rows is down to your code that waits for a stable CC value. Would it be possible to add a bit of logic that would switch when receiving X amounts of the same CC value? I know that I talked about a delay option before, but that was for visually cueing the row before actual selection.

So for example when used with my JS plugin and switching with a fader, the fact that the fader outputs many CC messages of the same value while traveling would mean that there is an instant switch, whereas using a normal fader or rotary with no plugin would still wait for a stable number.

Coming to think of it, because it would be possible to use buttons, pads or keys to output CC values it might be worthwhile putting an option for instant switch or stable switch in there.

Anyway, I'll leave you alone now!

Jeff0S commented 10 years ago

From swstim on September 05, 2010 16:03:26

OSX beta is now available in the downloads section.

Summary: SWS/S&M beta (build #6): issues/regressions

Jeff0S commented 10 years ago

From swstim on September 05, 2010 20:37:53

Jeff -

Respectfully, I'm not a huge fan of your "homemade" combo (dropdown) boxes. They are a little graphically confusing, and don't match the visual style of Reaper itself. (See attached.) Any particular reason you did them that way as opposed to using the standard control?

Tim

Attachment: combos.png

Jeff0S commented 10 years ago

From jeffos...@gmail.com on September 07, 2010 15:12:13

ha ha! TIM!! are you critisizing Justin's WDL_VirtualComboBox !? :))

It is used in REAPER itself. See the attached pic: the same dialog you shown, but with a send. You've got those same drop downs in a few places (little arrows on the pic). I use/like it for runtime positionning, WDL_VWnd (that can be made of WDL_VWnds), better "integrated" look.. .. but, here, yes, I agree. With some themes (well with most, as they rarely use the "3D" colors), er..

So, see the big arrows: I indeed made my own "homemade" S&M_VirtualComboBox (adaptive to clear/dark themes) that should be less confusing ?

Attachment: wdl_dropdown.jpg

Jeff0S commented 10 years ago

From swstim on September 07, 2010 15:35:26

Ah ha! I must check the code first before criticizing. Your version with the bounding box is indeed much clearer!

And yes, your reasoning makes perfect sense.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on September 08, 2010 11:22:41

ok, I'll commit that then :) Tim, in your 3 OSX snapshots, one of them shows a mix of yellow and white fonts.. do you remember which theme it was?

@theartfulregster: sorry, I forgot to reply.. Yes I see what you mean by "Would it be possible to add a bit of logic that would switch when receiving X amounts of the same CC value?" Your problem is that le live config MIDI actions ignores -consecutive- CC msg with same values (usual when processing CCs). But, knowing that, I think this can be handleled in your JS (sorry but I can't check more: busy these days!).

@musicbynumbers: just in case.. if you still around.. Snapshots: what you said in that other thread sounds good -if you're using the beta! this stuff is hotly random, so if you know even an hazardeous repro, what we'd just like to hear is something like "I can reproduce some issues with ntdll.dll / reaper.exe with the 'official' SWS Extension, but I'm not able to reproduce them with the beta". The few repros I know seem fixed now, but I don't own Kontakt so this could be simplier this way.

Jeff0S commented 10 years ago

From swstim on September 08, 2010 11:33:01

My OSX theme is the default one. I don't know why that text is yellow!

Jeff0S commented 10 years ago

From jeffos...@gmail.com on September 08, 2010 11:38:04

.. thanks Tim! I'm on it.. I also reproduce it now on Win with "MVH float" (excellent) theme!

Jeff0S commented 10 years ago

From musicbynumbers@gmail.com on September 08, 2010 12:27:51

Hi Jeffos,

Just had 5 mins to pop in here, unfortunately no time at the moment to do more tests but it might even just have been some bizarre link to the complex track I was doing. I have had a lot of problems with tracks involving video at the moment. The weird thing is it was fine when I tried using snapshots to change kontakt 4 presets (with samples) in a new empty project so perhaps it's a memory thing or maybe I will try again with latest beta (think I was on 5).

Will get back on testing when I can but not for a few days at least. :)

Jeff0S commented 10 years ago

From swstim on September 08, 2010 16:47:46

Hey Jeffos,

OSX build looks better. I've attached a screenshot of the FX chains window, notice the "dbl-click" label is overwritten. Everything else looks good!

Attachment: Picture 1.png

Jeff0S commented 10 years ago

From jeffos...@gmail.com on September 09, 2010 00:20:07

If I could have a sig over here, it would be "THANK YOU TIM!" :))

It should look better now (?) ( r195 ).

Tim (or any OSX user), when you'll have a moment, does the action help works on OSX (ie select an action "a", enter some blabla1, select an action "b", enter some blabla2, re-select "a" => blabla1 is correctly displayed) ? If it works, it would mean I have an "equivalent" for FindWindow() which isn't part of SWELL and other actions will work on OSX too (for ex. "SWS/S&M: Cycle focused window" that I enabled for test)

Jeff0S commented 10 years ago

From jeffos...@gmail.com on September 09, 2010 00:24:19

Tim, in your last snapshot, we can also see little -vertical- alignment issues. I didn't touch to that because it's ok on Win (well.. if you don't switch between themes that have different font sizes: static fonts, I'll see that later..)

Jeff0S commented 10 years ago

From swstim on September 09, 2010 20:46:34

Yes there's some slight vertical issues too, I wasn't too worried about that.

As for those specific things: Your SearchWindow isn't working on OSX. FindWindowEx, which is part of SWELL, is quite similar actually, and FindWindowEx doesn't work either. I stepped through both of these functions and it's not clear why they're not working at first glance - It looks like not all the windows are showing up, like they are not parented by the main wnd (GetMainHwnd()).

I recommend just #ifdefing those bits out.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on September 09, 2010 23:59:44

Thanks! SWELL's FindWindowEx(): yes, I bang my head on the walls with that one, that's why I made this SearchWindow() also with the hope it'll work on OSX.. .. but Ok, not much surprised: I'll ifdef that out later today (that was the only thing I had a serious doubt about, the rest "should" be ok on OSX).

Jeff0S commented 10 years ago

From mario.kr...@gmail.com on September 12, 2010 06:50:04

beta #6:

Jeff0S commented 10 years ago

From jeffos...@gmail.com on September 14, 2010 05:35:21

Mario, some tweaks have been made since the beta #6 => some of your points are already done, some will come later: 1) coming soon 2) done 3) learn (from track selection) sounds good! 4) (partially) done 5a) Less confusing link: yes, coming at some point (I need to design a few custom controls, including this one and with "link mouse pointer" on hover if possible). 5b) Custom action: hum.. it's border line but did you notice that this indirectly provides a feature!? (ease the copy/paste of complicated custom ids, example: "64a47399c7a71b4c85cbc450e9bf6cc1" from the web browser, I use that A LOT ;-)

Mario I'm disapointed you didn't caught the slighty faulty look of the Live Configs's tick boxes :)))) coming soon too..

Jeff0S commented 10 years ago

From mario.kr...@gmail.com on September 14, 2010 05:56:37

5b) The custom ID for the custom action should appear in the text window instead of using a link which will lead to an empty page on the Wiki.

Jeff0S commented 10 years ago

From theartfu...@googlemail.com on September 17, 2010 18:51:33

Jeffos, it is me who is late this time. :)

I fixed the JS plugin so that it only outputs a single CC value when there is several of the same value in a row and the Live Configs is still slightly audibly slower than the learning the Reaper native track selection actions. The Reaper track selection looks like it selects almost instantly in the GUI, but there is actually a delay in the audio.

The native actions in Reaper must be the fastest it could go though so it doesn't matter. I was just thinking of "going for it" with some different sounds.

Cheers

Paul

Jeff0S commented 10 years ago

From swstim on September 20, 2010 19:01:54

Since betas have been merged and released, closing this one. If there's things that are really important to you ( Mario) that haven't been covered yet, please open a new issue.

Released in v1.8.0 #1!

Status: Fixed

Jeff0S commented 10 years ago

From jeffos...@gmail.com on January 14, 2011 05:39:33

Most of the enhancements discussed here (inclding a configurable delay before applying Live Configs) gonna beta-released soon..

Jeff0S commented 10 years ago

From jeffos...@gmail.com on February 02, 2011 01:19:23

about comment 69: "I just noticed that "Hide/Show take volume/pan/mute envelope" actions are really slow..." => I improved them at that time but those actions are now (Beta 2.0.0 #8) even much more faster

Labels: -Type-Defect Type-Beta

Jeff0S commented 10 years ago

From jeffos...@gmail.com on September 13, 2011 14:18:15

(one year later..) form https://code.google.com/p/sws-extension/issues/detail?id=175#c66 (captain caveman): "If a track is selected that isn't in any Live Config rows before activating a Live Config row, that track is not de-selected. The Activate and Deactivate actions are performed on all selected tracks instead of just the one in the Live Config row."

Got a lot of feedback about that => I published that mod in r559 / r560 , from the whatsnew: +Auto track selection: make sure that only configured tracks are selected while performing "Activate" and "Deactivate" actions (and restore selection just after)

.. selection is restored so that what I replied in comment 67 still there too. Also, unticking the "Auto track selection" pref disables that (track selection totally unchanged)