search

reaper-oss / sws

The SWS extension is a collection of features that seamlessly integrate into REAPER, the Digital Audio Workstation (DAW) software by Cockos, Inc
https://www.sws-extension.org/
MIT License
456 stars 85 forks source link

Fix a crash in various FNG MIDI actions when the active MIDI editor is empty #1870

Closed cfillion closed 3 months ago

cfillion commented 6 months ago

MIDIEditor_GetTake is null after deleting the MIDI editor's opened item if the editor is configured to be per-project and "Contents > Options when using one MIDI editor per project > Close editor when the active media item is deleted in arrange view" is disabled.

The following actions were affected:

Fixes #1869

AppVeyorBot commented 6 months ago

:white_check_mark: Build sws 1102-master completed (commit https://github.com/reaper-oss/sws/commit/884ab636c8 by @cfillion)

Windows 64-bit - [build/BuildUtils/SWS_Template.ReaperLangPack](https://ci.appveyor.com/api/buildjobs/8tr4n1hjcvns0vau/artifacts/build/BuildUtils/SWS_Template.ReaperLangPack) - [build/BuildUtils/whatsnew.html](https://ci.appveyor.com/api/buildjobs/8tr4n1hjcvns0vau/artifacts/build/BuildUtils/whatsnew.html) - [build/reaper_sws-x64.dll](https://ci.appveyor.com/api/buildjobs/8tr4n1hjcvns0vau/artifacts/build/reaper_sws-x64.dll) - [build/reaper_sws-x64.pdb](https://ci.appveyor.com/api/buildjobs/8tr4n1hjcvns0vau/artifacts/build/reaper_sws-x64.pdb) - [build/sws-2.14.0.1-Windows-x64-fng-fix-empty-midi-editor-crash-884ab636.exe](https://ci.appveyor.com/api/buildjobs/8tr4n1hjcvns0vau/artifacts/build/sws-2.14.0.1-Windows-x64-fng-fix-empty-midi-editor-crash-884ab636.exe) - [build/sws_python64.py](https://ci.appveyor.com/api/buildjobs/8tr4n1hjcvns0vau/artifacts/build/sws_python64.py)
Windows 32-bit - [build/BuildUtils/SWS_Template.ReaperLangPack](https://ci.appveyor.com/api/buildjobs/sfqiwa3fuem5q392/artifacts/build/BuildUtils/SWS_Template.ReaperLangPack) - [build/BuildUtils/whatsnew.html](https://ci.appveyor.com/api/buildjobs/sfqiwa3fuem5q392/artifacts/build/BuildUtils/whatsnew.html) - [build/reaper_sws-x86.dll](https://ci.appveyor.com/api/buildjobs/sfqiwa3fuem5q392/artifacts/build/reaper_sws-x86.dll) - [build/reaper_sws-x86.pdb](https://ci.appveyor.com/api/buildjobs/sfqiwa3fuem5q392/artifacts/build/reaper_sws-x86.pdb) - [build/sws-2.14.0.1-Windows-x86-fng-fix-empty-midi-editor-crash-884ab636.exe](https://ci.appveyor.com/api/buildjobs/sfqiwa3fuem5q392/artifacts/build/sws-2.14.0.1-Windows-x86-fng-fix-empty-midi-editor-crash-884ab636.exe) - [build/sws_python32.py](https://ci.appveyor.com/api/buildjobs/sfqiwa3fuem5q392/artifacts/build/sws_python32.py)
macOS x86 64-bit - [build/sws-2.14.0.1-Darwin-x86_64-fng-fix-empty-midi-editor-crash-884ab636.dmg](https://ci.appveyor.com/api/buildjobs/p0ftvkpns2mdcqo0/artifacts/build/sws-2.14.0.1-Darwin-x86_64-fng-fix-empty-midi-editor-crash-884ab636.dmg) - [build/reaper_sws-x86_64.dylib](https://ci.appveyor.com/api/buildjobs/p0ftvkpns2mdcqo0/artifacts/build/reaper_sws-x86_64.dylib)
macOS x86 32-bit - [build/reaper_sws-i386.dylib](https://ci.appveyor.com/api/buildjobs/79yhx3l4lslxd70w/artifacts/build/reaper_sws-i386.dylib) - [build/sws-2.14.0.1-Darwin-i386-fng-fix-empty-midi-editor-crash-884ab636.dmg](https://ci.appveyor.com/api/buildjobs/79yhx3l4lslxd70w/artifacts/build/sws-2.14.0.1-Darwin-i386-fng-fix-empty-midi-editor-crash-884ab636.dmg)
macOS ARM 64-bit - [build/reaper_sws-arm64.dylib](https://ci.appveyor.com/api/buildjobs/k2nopj5np0tnlyvg/artifacts/build/reaper_sws-arm64.dylib) - [build/sws-2.14.0.1-Darwin-arm64-fng-fix-empty-midi-editor-crash-884ab636.dmg](https://ci.appveyor.com/api/buildjobs/k2nopj5np0tnlyvg/artifacts/build/sws-2.14.0.1-Darwin-arm64-fng-fix-empty-midi-editor-crash-884ab636.dmg)
Linux x86 64-bit - [build/reaper_sws-x86_64.so](https://ci.appveyor.com/api/buildjobs/oh89s2ava4c1ryyl/artifacts/build/reaper_sws-x86_64.so) - [build/sws-2.14.0.1-Linux-x86_64-fng-fix-empty-midi-editor-crash-884ab636.tar.xz](https://ci.appveyor.com/api/buildjobs/oh89s2ava4c1ryyl/artifacts/build/sws-2.14.0.1-Linux-x86_64-fng-fix-empty-midi-editor-crash-884ab636.tar.xz)
Linux x86 32-bit - [build/reaper_sws-i686.so](https://ci.appveyor.com/api/buildjobs/qbmycimvh4u0ocq9/artifacts/build/reaper_sws-i686.so) - [build/sws-2.14.0.1-Linux-i686-fng-fix-empty-midi-editor-crash-884ab636.tar.xz](https://ci.appveyor.com/api/buildjobs/qbmycimvh4u0ocq9/artifacts/build/sws-2.14.0.1-Linux-i686-fng-fix-empty-midi-editor-crash-884ab636.tar.xz)
Linux ARM 64-bit - [build/sws-2.14.0.1-Linux-aarch64-fng-fix-empty-midi-editor-crash-884ab636.tar.xz](https://ci.appveyor.com/api/buildjobs/lt1yw6wkm4776sf9/artifacts/build/sws-2.14.0.1-Linux-aarch64-fng-fix-empty-midi-editor-crash-884ab636.tar.xz) - [build/reaper_sws-aarch64.so](https://ci.appveyor.com/api/buildjobs/lt1yw6wkm4776sf9/artifacts/build/reaper_sws-aarch64.so)
Linux ARM 32-bit - [build/reaper_sws-armv7l.so](https://ci.appveyor.com/api/buildjobs/5qvkxfhhcwyv4tw8/artifacts/build/reaper_sws-armv7l.so) - [build/sws-2.14.0.1-Linux-armv7l-fng-fix-empty-midi-editor-crash-884ab636.tar.xz](https://ci.appveyor.com/api/buildjobs/5qvkxfhhcwyv4tw8/artifacts/build/sws-2.14.0.1-Linux-armv7l-fng-fix-empty-midi-editor-crash-884ab636.tar.xz)