search

reaper-oss / sws

The SWS extension is a collection of features that seamlessly integrate into REAPER, the Digital Audio Workstation (DAW) software by Cockos, Inc
https://www.sws-extension.org/
MIT License
455 stars 85 forks source link

Markerlist - Reorder region IDs crashes Reaper in particular scenario #575

Closed Jeff0S closed 10 years ago

Jeff0S commented 10 years ago

From Brado231 on May 19, 2013 05:53:47

What steps will reproduce the problem? 1. Create new track

  1. Press play
  2. Add 6 markers about 1 second apart each
  3. Stop play
  4. Load SWS Markerlist
  5. Right click in SWS Markerlist and select Convert Markers to Regions
  6. You should notice that the regions are numbered 6,1,2,3,4,5 with no trailing marker. I think this is where the problem begins.
  7. Right click in SWS Markerlist and choose Reorder Region IDs.
  8. Reaper crashes.

NOTE: This only seems to happen on 64-bit Reaper / 64-bit SWS Ext. Doesn't happen on 32-bit Reaper with 32-bit SWS Ext. The 32-bit version that works orders the markers correctly during step 6 (0,1,2,3,4,5 - with trailing Marker (6)) and doesn't crash when Step 8 is run.

I'm using Windows 8 Pro 64-bit / Reaper 4.41pre5 64-bit / SWS Ext 2.3.0 #17 64-bit on the system that shows the problem. 32-bit setup that works fine is Windows 8 Pro 64-bit / Reaper 4.402 32-bit / SWS Ext 2.3.0 #17 32-bit (on same computer). What is the expected output? What do you see instead? Expected output is region IDs reordered with no crash. It seems to work OK if there are items in the project but crashes when the project is new with no items.

What version of SWS extension are you using? (Extensions -> About SWS...) 2.3.0 #17 What is your Reaper version number and CPU architecture (e.g. Reaper 3.75 x64)? 4.41pre5 64-bit What operating system are you running? (e.g. Windows XP/7, OSX 10.5.8 etc, 64bit?) Windows 8 Pro 64-bit

I will try to fix it if I can get some time unless someone has time to fix it beforehand?

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=575

Jeff0S commented 10 years ago

From jeffos...@gmail.com on June 25, 2013 08:44:10

I was not able to repro this neither in win xp, nor OSX i386 nor OSX x86-x64. Can't test the BR's plateform ATM though (Win x64)

Jeff0S commented 10 years ago

From Brado231 on June 26, 2013 05:35:23

I can confirm it still happens in the 64-bit versions using Reaper 4.5 pre11 and SWS 2.3.0 #18. It only happens when there aren't any items on any tracks. If there is at least one item on a track it doesn't happen and works fine.

Jeff0S commented 10 years ago

From Brado231 on June 26, 2013 05:38:30

I meant 4.5 rc11 above. Sorry I haven't been able to try to fix this issue. Have been under the pump big time at work the last month or so.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on June 27, 2013 01:09:31

Thanks Brad! I can repro all the time now.. It turns out it's a native crash, I entered a BR here: http://forum.cockos.com/project.php?issueid=4865 (on a sidenote: MarkersToRegions(COMMAND_T*) should not crash but it looks very wrong to me..)

Jeff0S commented 10 years ago

From Brado231 on June 27, 2013 01:56:09

Awesome! Thanks Jeffos. Much appreciated. I saw your post on the Reaper Pre-release forum and thought you must have found it :-)

Status: New

Jeff0S commented 10 years ago

From Brado231 on June 27, 2013 01:56:50

Whoops. Changed status accidentially.

Status: Investigating

Jeff0S commented 10 years ago

From Brado231 on June 29, 2013 20:12:13

This is fixed now in Reaper 4.5rc12 x64 with SWS Extensions 2.3.0 #19. Thanks Jeffos!!

Status: Fixed

Jeff0S commented 10 years ago

From jeffos...@gmail.com on July 01, 2013 05:45:26

Yes, the crash has been fixed 4.5rc12 but AddProjectMarker2() is still broken (does not behave anymore like in v4.402, ie. like the API header states - and our code relies on this... => Let's bump this if it still not fixed in the few next release!