search

reaper-oss / sws

The SWS extension is a collection of features that seamlessly integrate into REAPER, the Digital Audio Workstation (DAW) software by Cockos, Inc
https://www.sws-extension.org/
MIT License
455 stars 85 forks source link

Converting markers to regions bug #601

Closed Jeff0S closed 10 years ago

Jeff0S commented 10 years ago

From OuttrOMu...@gmail.com on October 05, 2013 02:27:18

What steps will reproduce the problem? create some markers in an empty project run action _SWSMARKERLIST13 (markers to regions) during project playback What is the expected output? What do you see instead? 1. shouldn't affect playback, but it moves the play cursor to the project start.

  1. the regions should be in the same order as the markers were, but the action has moved the last marker to the project start and now there are two regions overlapped at project start.

run related action _SWSMARKERLIST14 alternately with _SWSMARKERLIST13 (convert between markers and regions repeatedly.

you appear to get one less region each time you go back and forth, but they didn't go away, they just got stacked at the project start, which you can see clearly in the SWS Marker List...

What version of SWS extension are you using? (Extensions -> About SWS...) 2.4.0 #1 What is your Reaper version number and CPU architecture (e.g. Reaper 3.75 x64)? 4.52 x64 What operating system are you running? (e.g. Windows XP/7, OSX 10.5.8 etc, 64bit?) win7 x64

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=601

Jeff0S commented 10 years ago

From jeffos...@gmail.com on October 10, 2013 01:37:14

@IXix: I was quite sure you replied to this issue ( https://groups.google.com/forum/?fromgroups#!topic/sws-updates/WHc_0NKPAuE ) but I can't see your posts anymore here... strange. Anyway, may be it is not related (I did not look into the code...) but I wanted to ping you about some recent API changes: AddProjectMarker functions do not provide region/marker numbers as they used to do (try REAPER v4.402 vs 4.5). It is better a plain crash though: see https://code.google.com/p/sws-extension/issues/detail?id=575 which led to to this BR: http://forum.cockos.com/project.php?issueid=4865 => fixed now, but with the functionnal change I was talking about..

Also, I personnaly agree with the report here: for me, things should be designed so that convert to regions + convert to markers = no-op, and vice et versa. In other words, not sure these actions should "invent" a marker/region at the start of the project...

Jeff0S commented 10 years ago

From OuttrOMu...@gmail.com on October 10, 2013 18:06:05

thanks for the responses, why this is an issue for me is 1: i try to make sure custom actions do not disrupt playback, as myself and others like to edit during playback; and 2: i used converting regions to markers and back to avoid creating overlapping regions, which imo is a bad, annoying feature of regions.

ultimately i tried to create an action to add a new, non-overlapping region at time selection for use on the fly (during playback).

how it would make the most sense to me would be to create markers for the start and end of regions (when converting to markers), ignore the project start if no marker exists, and avoid creating multiple markers at the same location. then the only difference when converting back to regions would be that any space between regions before would now also have a region, which i could not complain about. i think that would be the closest possible match to expectation for those actions.

that way you don't lose the last region because it's end point wasn't marked and you dont gain a region at project start unless desired, and you never get stacks of markers or regions anywhere.

Jeff0S commented 10 years ago

From considin...@gmail.com on October 11, 2013 12:40:40

Yeah, I see the point and I don't mind changing it. I'm up to my ears in maths that I don't understand now but I'll sort it out soon.

@Jeffos Thanks for the heads up about API changes. I've noticed some odd region behaviour myself recently so I wonder if the issues you've linked might be what I was seeing.

Jeff0S commented 10 years ago

From jeffos...@gmail.com on November 05, 2013 09:46:55

the "playback disruption" part of this bug report is fixed for the next build ( r1157 )

Status: Started

Jeff0S commented 10 years ago

From considin...@gmail.com on November 14, 2013 06:27:20

Nice one Jeffos. I couldn't work out how to do that. I'll sort the rest of it as soon as I figure out how to disentangle all my experimental changes with SVN. I really should learn more about SVN. :(