reaper-oss / sws

The SWS extension is a collection of features that seamlessly integrate into REAPER, the Digital Audio Workstation (DAW) software by Cockos, Inc
https://www.sws-extension.org/
MIT License
448 stars 85 forks source link

SWS beta: track template slots and fx chains doesn't work: don't save settings #935

Closed shibbolethwithout closed 5 years ago

shibbolethwithout commented 6 years ago

track template slots and fx chains doesn't work: don't save settings. After reboot Reaper slots list is clear. REAPER v5.70

cfillion commented 6 years ago

(Previous issue discussing the matter: #934)

This happens because WDL is missing UTF-8 implementations of GetPrivateProfileSection and WritePrivateProfileSection.

burdak commented 6 years ago

I have the same problem. You could tell in more detail how to solve it? Thanks.

cfillion commented 6 years ago

I've updated my build at https://cfillion.ca/files/sws/utf8-resource-path/ with an additional fix for this.

There is at least one remaining issue: the content of S&M.ini is limited to the current ANSI code page. This means some settings may not always work in every cases.

The solution seems to be having SWS create the file with a UTF-16 BOM before letting {Get,Write}PrivateProfile* read/write into it. But this doesn't help existing users and is probably not portable with macOS and Linux.

REAPER's own reaper.ini is also affected by this since 5.60, eg. it doesn't correctly save last used projects with Unicode characters outside of the code page.

Please bump this thread if this affects you: https://forum.cockos.com/showthread.php?p=1927329.