reaper-oss / sws

The SWS extension is a collection of features that seamlessly integrate into REAPER, the Digital Audio Workstation (DAW) software by Cockos, Inc
https://www.sws-extension.org/
MIT License
448 stars 85 forks source link

Automation items: bugs and enhancements (collection) #954

Open nofishonfriday opened 6 years ago

nofishonfriday commented 6 years ago

Note sure if it makes sense opening a separate issue for all SWS things that broke with the addition of automation items (AI's) (at least until someone starts working on it), so for now here's a collection issue. Feel free to add or notify me so I can update the first post.

Broken:

Test code:

function msg(m)
  return reaper.ShowConsoleMsg(tostring(m) .. "\n")
end

lastDetailsOut = -1

function GetMouseCursorDetails()
  windowOut, segmentOut, detailsOut = reaper.BR_GetMouseCursorContext()
  if lastDetailsOut ~= detailsOut then
    msg("detailsOut: " .. detailsOut) 
  end
  lastDetailsOut = detailsOut
  reaper.defer(GetMouseCursorDetails)
end

GetMouseCursorDetails()

edit; For takes envelopes the detection is correct (makes sense as they weren't shifted). There's a ENV_GAP constant which probably needs adjustment (for fixing point / segment detection offset in env. lanes).

Enhancements:

studiohoell commented 2 years ago

Just a reminder from my side that SWS(/BR) actions/scripts related to envelopes don't work with AIs. Thank you all for considering when updating these actions.