Support more websites and fix UnmarshallingError on @graph

reaper47 / recipya

A clean, simple and powerful recipe manager your whole family will enjoy.

https://recipes.musicavis.ca

GNU General Public License v3.0

147 stars 10 forks source link

Support more websites and fix UnmarshallingError on @graph #353

Closed jesp1999 closed 1 week ago

jesp1999 commented 2 weeks ago

Diagnose and fix issue for

[X] downshiftology.com (403, needed User-Agent header, still appears to give issues sometimes, might be worth future investigation)
[X] wellplated.com

Adds support for

[x] avocadoskillet.com
[x] beyondkimchee.com
[X] chatelaine.com
[x] chejorge.com
[x] cuisineandtravel.com
[x] daringgourmet.com
[x] dreenaburton.com
[x] elephantasticvegan.com
[x] entertainingwithbeth.com
[x] feastingathome.com
[x] foodal.com
[x] foodbymaria.com
[x] foodiecrush.com
[x] foolproofliving.com
[x] gastroplant.com
[x] goodto.com
[x] greenevi.com
[x] healthylittlefoodies.com
[x] jaroflemons.com
[X] natashaskitchen.com

Albums listened to while writing this PR

Opeth - Damnation
Opeth - Still Life
Archspire - Relentless Mutation
Shadow of Intent - Reclaimer

jesp1999 commented 2 weeks ago

Thanks for the extensive review! This is my first time working in Go so the feedback is really helpful. I'll account for the changes as soon as I'm able to.

reaper47 commented 2 weeks ago

You are welcome! It's my pleasure to help you. Amazing PR description by the way. I love the extra touch with the albums.

Regarding the keywords constraint bug, I wonder what's causing it. The table is defined here and the insert here. I tried reproducing it by importing recipes with multiple keywords on two accounts but no error occurred.

jesp1999 commented 2 weeks ago

You are welcome! It's my pleasure to help you. Amazing PR description by the way. I love the extra touch with the albums.

Thanks! I took inspiration from your readme 😁

Regarding the keywords constraint bug, I wonder what's causing it. The table is defined here and the insert here. I tried reproducing it by importing recipes with multiple keywords on two accounts but no error occurred.

I'm not sure exactly, I'll try and replicate it for a future issue once I finish this PR.

jesp1999 commented 1 week ago

To prevent this PR from getting too large, I'm going to request review in its current state, modify the description, and punt tackling the remainder of the items for future pull requests.

reaper47 commented 1 week ago

Excellent work on these websites and nigello! You fully understood how adding/supporting/verifying websites works. I will check both of your PRs tomorrow.