search

reaper7 / SDM_Energy_Meter

reading SDM72 SDM120 SDM220 SDM230 SDM630 modbus energy meters from arduino (esp8266, esp32, avr)
247 stars 97 forks source link

Added registers for DDM18SD #44

Closed jeroenst closed 4 years ago

reaper7 commented 4 years ago

Hi! Have you tested this device? it works?

jeroenst commented 4 years ago

Not yet, I did integrate the registers from the documentation. I will receive the device 15-5-2020 and will install and test it the same day.

To be continued...

reaper7 commented 4 years ago

Ok, then we'll wait for physical tests... if everything goes well we will add Your integration.

Let me know when you check.

jeroenst commented 4 years ago

Sorry, I don't think I will use this device soon, for now I use a zmai90. So at this moment I won't test this code.

Jestergnet commented 4 years ago

I saw the code, I'm checking it. Made changes, asked for it and nothing changed? What do I need to do?

Jestergnet commented 4 years ago

I checked it works.

jeroenst commented 4 years ago

Please merge now or has been tested.

reaper7 commented 4 years ago

Please update your copy of this repo because structure of SDM.h and nomenclature of registry names has been changed. You must create definitions for the new device according to the example from SDM.h (example from lines 194-202)

reaper7 commented 4 years ago

done!

digimp commented 3 years ago

Looking for see this device (DDM18SD) working found your contribution here. On the code of the tasmota sensor there isn't , or I have'nt found, nothing for this device. So finally this is the reason why it doesn't work in my hands. Do I have to add this register on a override file or I have to start to compile a full file from the beginning to the end ?

reaper7 commented 3 years ago

I don't use tasmota and I don't know how it's built... You can try of course ...

digimp commented 3 years ago

Ah, thanks for quick answer! I'll try to do what I can, not easy. Thanks for your work, I'll have anyway the chance to read my meter.