reapit / foundations

Foundations platform mono repo
57 stars 21 forks source link

BER Information not coming through API #10610

Closed darraghmcgrath3 closed 7 months ago

darraghmcgrath3 commented 7 months ago

Please take a look at our FAQ's before submitting an issue, as your question may already be covered in the documentation https://foundations-documentation.reapit.cloud/faqs

Hi there, a developer of ours is trying to pull BER information through the API using our (SFG) app Mood DS Service, but it isn't coming through. The request put through is ("/properties/?pageSize=25&pageNumber=1&sortBy=-modified&embed=images&embed=negotiator&officeId=" + officeId + "&sellingStatus=forSale&internetAdvertising=true&extrasField=pBERRating&extrasField=pBERNumber&extrasField=pEPI&extrasField=pBERExempt");. but the only thing visible under EPC is the below:

image

Could you please advise why that isn't coming through? Thanks, Darragh

AshDeeming commented 7 months ago

Hi @darraghmcgrath3 Please could you confirm the property ID the error is from?

darraghmcgrath3 commented 7 months ago

Hi Ash,

There is no particular property, the developer is looking to pull BER information for all properties that the app is installed for, but does not receive BER information for any.

For example, the screenshot below is from the data received for BLA230076.

Many thanks, Darragh

Darragh McGrath Web Operations Executive Sherry FitzGerald Silverstone House, Ballymoss Road, Sandyford, Dublin 18, D18 A7K7

Direct: +353 1 237 6338 Mobile: +353 87 709 3553 Email: @.*** Web: www.sherryfitz.ie

I have sent this email at a time that is convenient for me. I do not expect you to respond to it outside of your usual working hours. ​ Sign up to mySherryFitz now to book viewings, make offers, see existing bids, arrange property notifications and chat to us online – we’re here to help! Click here to view the Sherry FitzGerald Privacy Policy Please consider the environment before printing this email

Sherry FitzGerald Group Ireland Holdings Limited. Registered in Ireland, CRO no 623927. Registered office: Silverstone House, Ballymoss Road, Sandyford, Dublin 18. D18 A7K7.

The contents of this e-mail are Subject to Contract /Contract denied. ​ ​This e-mail and any files transmitted with it are confidential and are intended solely for the use of the intended recipient. Any unauthorised direct or indirect dissemination, distribution or copying of this message and any attachments is strictly prohibited. If you have received this e-mail or any file attachment transmitted with it in error, please notify Sherry FitzGerald at @.*** ​ ​This email has been scanned for computer viruses.

A part of the Sherry FitzGerald Group Residential | New Homes | Lettings | Mortgages From: Ash @.> Sent: Monday, January 22, 2024 10:36 AM To: reapit/foundations @.> Cc: Darragh McGrath @.>; Mention @.> Subject: Re: [reapit/foundations] BER Information not coming through API (Issue #10610)

You don't often get email from @.**@.>. Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

Hi @darraghmcgrath3https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darraghmcgrath3&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=EKiTAGsfuGB-9lhLrNf3LdUu1hCXkyYLuoQWuKT7rkY&m=AZQnnMNfr51v3zHuxq1bvpuI5JBRlxPW2a9xy3i8s3BDwpYgb829uPzgku421FqV&s=EtZFLam4FqimGHZrS9G3ZE-keCLga0VwlnsAeNgPbGE&e= Please could you confirm the property ID the error is from?

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_reapit_foundations_issues_10610-23issuecomment-2D1903701426&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=EKiTAGsfuGB-9lhLrNf3LdUu1hCXkyYLuoQWuKT7rkY&m=AZQnnMNfr51v3zHuxq1bvpuI5JBRlxPW2a9xy3i8s3BDwpYgb829uPzgku421FqV&s=4vo5rSAnEJ0wo-CDK34C2k6cT4kkXNvfd7Q0aUSBfm0&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_A4KQQZBAPRETGG2HUORTRPTYPY6IZAVCNFSM6AAAAABCE3Q4F2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBTG4YDCNBSGY&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=EKiTAGsfuGB-9lhLrNf3LdUu1hCXkyYLuoQWuKT7rkY&m=AZQnnMNfr51v3zHuxq1bvpuI5JBRlxPW2a9xy3i8s3BDwpYgb829uPzgku421FqV&s=BZorekzuFu1tGc0xQc71NVgLDWhpnm9tpKlq12lBdD4&e=. You are receiving this because you were mentioned.Message ID: @.**@.>>


This email has been scanned for spam and viruses. Click herehttps://spambrella.cloud-protect.net/app/report_spam.php?mod_id=11&mod_option=logitem&report=1&type=easyspam&k=k1&payload=53616c7465645f5ffbb76aaafc3fced830645545a371a86a17ec38ed94494745049f91cf0b57bb0ce732852e3703256cfaf82016bfe31d9923c9554e8f11068696d77fe0a1a2a0f61db86901ef450e02be05e3600aaa115b63f7824a85c34ab40a99e99e488f2ceee1599a816800de0f3f3d57f8a3d5b93a072d0a1634b63060e6257d013d1bfce8f8468533914309fce66cfec6ef3b89c4c677949ca9c6e6bc to report this email as spam.

AshDeeming commented 7 months ago

Hi @darraghmcgrath3 That particular property is exempt: image

darraghmcgrath3 commented 7 months ago

Hi Ash,

That is correct, but you should still see the fields as blank, and a field called BERExempt marked as True. In this case, nothing is coming across. It is similar for DNL230208, which is not BER Exempt.

Thanks, Darragh

Darragh McGrath Web Operations Executive Sherry FitzGerald Silverstone House, Ballymoss Road, Sandyford, Dublin 18, D18 A7K7

Direct: +353 1 237 6338 Mobile: +353 87 709 3553 Email: @.*** Web: www.sherryfitz.ie

I have sent this email at a time that is convenient for me. I do not expect you to respond to it outside of your usual working hours. ​ Sign up to mySherryFitz now to book viewings, make offers, see existing bids, arrange property notifications and chat to us online – we’re here to help! Click here to view the Sherry FitzGerald Privacy Policy Please consider the environment before printing this email

Sherry FitzGerald Group Ireland Holdings Limited. Registered in Ireland, CRO no 623927. Registered office: Silverstone House, Ballymoss Road, Sandyford, Dublin 18. D18 A7K7.

The contents of this e-mail are Subject to Contract /Contract denied. ​ ​This e-mail and any files transmitted with it are confidential and are intended solely for the use of the intended recipient. Any unauthorised direct or indirect dissemination, distribution or copying of this message and any attachments is strictly prohibited. If you have received this e-mail or any file attachment transmitted with it in error, please notify Sherry FitzGerald at @.*** ​ ​This email has been scanned for computer viruses.

A part of the Sherry FitzGerald Group Residential | New Homes | Lettings | Mortgages From: Ash @.> Sent: Monday, January 22, 2024 2:14 PM To: reapit/foundations @.> Cc: Darragh McGrath @.>; Mention @.> Subject: Re: [reapit/foundations] BER Information not coming through API (Issue #10610)

You don't often get email from @.**@.>. Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

Hi @darraghmcgrath3https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darraghmcgrath3&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=EKiTAGsfuGB-9lhLrNf3LdUu1hCXkyYLuoQWuKT7rkY&m=jLBsqGWhXDaaqtcK4JqyL7g2Eul5alLvYrcCiD1W3hxxWBfbQXFTi-IIIjjfZSop&s=JYm0S07LZsba5Hhu8HfkMly3shona1oNUrs2n6zrJ4A&e= That particular property is exempt: image.png (view on web)https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_reapit_foundations_assets_61687775_0a5cec13-2D2145-2D48ca-2D91e6-2D1d5f2645c1b5&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=EKiTAGsfuGB-9lhLrNf3LdUu1hCXkyYLuoQWuKT7rkY&m=jLBsqGWhXDaaqtcK4JqyL7g2Eul5alLvYrcCiD1W3hxxWBfbQXFTi-IIIjjfZSop&s=bgkWyJu8zGGf0UvY0FDtTDbH1JjBeLHolYhZ4S6UURI&e=

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_reapit_foundations_issues_10610-23issuecomment-2D1904090171&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=EKiTAGsfuGB-9lhLrNf3LdUu1hCXkyYLuoQWuKT7rkY&m=jLBsqGWhXDaaqtcK4JqyL7g2Eul5alLvYrcCiD1W3hxxWBfbQXFTi-IIIjjfZSop&s=g0PdReYrdzM-kJPV_sOZhgDQbkBjrfi3shQet4nsRfE&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_A4KQQZGWJVTRE3SGJMQFGDTYPZX2RAVCNFSM6AAAAABCE3Q4F2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGA4TAMJXGE&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=EKiTAGsfuGB-9lhLrNf3LdUu1hCXkyYLuoQWuKT7rkY&m=jLBsqGWhXDaaqtcK4JqyL7g2Eul5alLvYrcCiD1W3hxxWBfbQXFTi-IIIjjfZSop&s=jC7_FKUH3EC4jON8dC9JpxK1nr0sxekb6h_NPwzbPrY&e=. You are receiving this because you were mentioned.Message ID: @.**@.>>


This email has been scanned for spam and viruses. Click herehttps://spambrella.cloud-protect.net/app/report_spam.php?mod_id=11&mod_option=logitem&report=1&type=easyspam&k=k1&payload=53616c7465645f5facba98702ffe8939e4b357c5b84f8a4628b0b20441e4e58587616d36796078325dc81fe34eae09290d6488abc11fb896129f0480fa0685e87f1632a1cfde55b530838c73757628bbc6ca6f526d698e136d043a905d79dc4c86fcebdad81107386bd06393ea22386e9fc5e4dee5343754114e1935a81dba8463e89fcc39a8b1a9165a833b03951b00351a6a4ac708369af9a43276ccb1558f to report this email as spam.

AshDeeming commented 7 months ago

Thanks @darraghmcgrath3 I'll tag our back end team to review in more detail

plittlewood-rpt commented 7 months ago

Hi @darraghmcgrath3, BER information can be found at [root].regional.irl in the PropertyModel. EPC information is for stock in England. Note that the property's country must be set correctly (Ireland) for this model to get populated. Please let me know if this doesn't answer your query.

plittlewood-rpt commented 7 months ago

Looking at the query above they are requesting the BER information as extrasFields, in which case they'll find them in the extrasfield collection on the property model. It's likely this was set up prior to the regional models being added, but they should see the same data in both places. It's preferable to use the regional models over the extrasField mechanism as it keeps the query strings a little lighter.

plittlewood-rpt commented 7 months ago

Hi @darraghmcgrath3 can you let me know if the above sorted your problem? Thanks

darraghmcgrath3 commented 7 months ago

Hi @plittlewood-rpt , apologies, that solved the issue - many thanks for your help. Darragh

github-actions[bot] commented 7 months ago

We have recently requested additional information relating to the issue you have raised. Please can you take the time to review this ticket and where applicable, provide the information requested. For more information on our processes, please click here

github-actions[bot] commented 7 months ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here