search

reapit / foundations

Foundations platform mono repo
57 stars 21 forks source link

Letting Status params not being respected in get Properties #10710

Closed hivetom closed 7 months ago

hivetom commented 7 months ago 
          Hi @plittlewood-rpt @AshDeeming @cduggan-reapit ,

Further to this issue, we have been advised by clients of additional properties not being imported where an arrangingTenancy tenancy is set. We have investigated this and replicated with SBOX data as follows:

Property: MKT210309 Tenancy: MKT210158 (status: Arranging Tenancy)

Using this query, we are unable to retrieve the aforementioned property:

properties?pageNumber=1&pageSize=100&officeId=MKT&embed=tenancies&marketingMode=letting&marketingMode=sellingAndLetting&lettingStatus=arrangingTenancy&lettingStatus=arrangingTenancyUnavailable&lettingStatus=tenancyCurrent

Fetching the property directly via its ID reveals:

"marketingMode" => "letting", "letting" => [ ... "status" => "arrangingTenancyUnavailable", ], ... "_embedded" => [ "tenancies" => [ [ "id" => "MKT210158", "status" => "arranging", ... ] ] ]

Any info you could share on this would be greatly appreciated.

Kind regards

Originally posted by @hivetom in https://github.com/reapit/foundations/issues/10031#issuecomment-1936015989

HollyJoyPhillips commented 7 months ago

Hi @hivetom, one of our engineers ran the same query via the swagger in the DeveloperPortal and that property was returned:

https://platform.reapit.cloud/properties/?pageSize=100&pageNumber=1&embed=tenancies&lettingStatus=arrangingTenancyUnavailable&lettingStatus=arrangingTenancy&lettingStatus=tenancyCurrent&marketingMode=letting&marketingMode=sellingAndLetting&officeId=MKT

image

hivetom commented 7 months ago

Hi @HollyJoyPhillips ,

Thanks for this. Is there a private/secure area where we can disclose real-world examples that are not SBOX data please?

Kind regards

HollyJoyPhillips commented 7 months ago

Hi @hivetom, of course, you can send examples to sinfo@reapitfoundations.zendesk.com. Thanks.

HollyJoyPhillips commented 7 months ago

Hi @hivetom, do you have any other examples or are happy for us to close this ticket?

github-actions[bot] commented 7 months ago

We have recently requested additional information relating to the issue you have raised. Please can you take the time to review this ticket and where applicable, provide the information requested. For more information on our processes, please click here

hivetom commented 7 months ago

Hi @HollyJoyPhillips I have sent a live example via email just now for you to review. Kind regards

HollyJoyPhillips commented 7 months ago

Internal Issue '1041'

HollyJoyPhillips commented 7 months ago

Hi @hivetom, I've replied to the ticket. Please confirm if that answers your query. Thanks.

hivetom commented 7 months ago

Thank you @HollyJoyPhillips , that does indeed answer our query. Kind regards.

github-actions[bot] commented 7 months ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here