reapit / foundations

Foundations platform mono repo
57 stars 21 forks source link

Reapit API's 500 error code #11010

Closed KeithLowe closed 4 months ago

KeithLowe commented 5 months ago

Issue with Reapit API, checked the logs and looks like we're getting 500s back from Reapit for QA + Live. Test/uat appear to be OK. Mostly looks like GetAppointment requests but there's a GetContacts one in there too - so could be all requests.

Status: 500 Response: {"statusCode":500,"dateTime":"2024-04-10T14:49:30.1788935Z","description":"An unexpected error has been encountered when fulfilling this request. This incident has been logged and will be investigated. Please try again."})

To Reproduce Some example calls from our tests earlier today: ___ (13:29:46.5677) GET https://platform.reapit.cloud/appointments/?pageNumber=1&pageSize=100&embed=property&negotiatorId=VVAI&negotiatorId=FRT8&negotiatorId=HWS9&negotiatorId=OP32&negotiatorId=FT72&negotiatorId=JCD4&negotiatorId=KRW4&negotiatorId=RTY7&negotiatorId=MNTD&negotiatorId=MWL&negotiatorId=LPP1&negotiatorId=ROU5&negotiatorId=K973&negotiatorId=SHP6&includeCancelled=false&includeUnconfirmed=true&fromArchive=false&officeId=MLB&start=2024-04-03T00%3A00%3A00.0000000Z&end=2024-05-22T00%3A00%3A00.0000000Z Reapit Request Id: fd46bd66-e215-45db-a959-0374d95a42c7 Reapit Request Time: 00:00:25.2321882 Response: 500 ____ (13:43:38.5594) GET https://platform.reapit.cloud/appointments/?pageNumber=1&pageSize=100&embed=property&negotiatorId=VVAI&negotiatorId=FRT8&negotiatorId=HWS9&negotiatorId=OP32&negotiatorId=FT72&negotiatorId=JCD4&negotiatorId=KRW4&negotiatorId=RTY7&negotiatorId=MNTD&negotiatorId=MWL&negotiatorId=LPP1&negotiatorId=ROU5&negotiatorId=K973&negotiatorId=SHP6&includeCancelled=false&includeUnconfirmed=true&fromArchive=false&officeId=MLB&start=2024-04-03T00%3A00%3A00.0000000Z&end=2024-05-22T00%3A00%3A00.0000000Z Reapit Request Id: 294878bb-2297-4db8-a2a6-5f77595fc1aa Reapit Request Time: 00:00:25.3080642 Response: 500

Using the live credentials - both had the same response as above in the debug logs

Expected behaviour API transaction to be successfully processed!

Screenshots n/a

github-actions[bot] commented 5 months ago

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

github-actions[bot] commented 5 months ago

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here

RWilcox-Reapit commented 4 months ago

Hi @KeithLowe I have been looking into this issue today to understand what's causing this for a small number of clients. In the instances and others pulled from logs I can see it's related to some negotiators being associated to large number of appointments.

One suggestion to prevent this for the immediate future would be to narrow down the start and end date params. The examples given above have a 7 week range which will result in a larger DB hit.

Can I ask the use case for pulling back 7 weeks worth of appointments in one hit, are you performing a data sync or is this for a screen?

I'm currently looking at ways to improve this query to prevent it timing out, this may end up being broken up into another ticket, I'll keep you updated on here.

Thanks

KeithLowe commented 4 months ago

Morning!

Thanks for the update, happy to assist with testing any changes you may need to make. Looping in Louis for info and more background to the request reasons.

Keith

Keith Lowe | Development Manager | IT Solutions & Development [Connells Group Logo]http://www.connellsgroup.co.uk/ 6 Caldecotte Lake Business Park, Milton Keynes Buckinghamshire, MK7 8JT Tel: 01908 722865<tel:01908%20722865> Email: @.**@.> Web: www.connellsgroup.co.ukhttp://www.connellsgroup.co.uk

From: RWilcox-Reapit @.> Sent: Wednesday, May 29, 2024 4:32 PM To: reapit/foundations @.> Cc: Keith Lowe @.>; Mention @.> Subject: Re: [reapit/foundations] Reapit API's 500 error code (Issue #11010)

WARNING: This message is from outside of the Group, are you sure it is GENUINE? NEVER click on a link or open an attached document unless you are expecting to receive them. NEVER share your login details.

Hi @KeithLowehttps://github.com/KeithLowe I have been looking into this issue today to understand what's causing this for a small number of clients. In the instances and others pulled from logs I can see it's related to some negotiators being associated to large number of appointments.

One suggestion to prevent this for the immediate future would be to narrow down the start and end date params. The examples given above have a 7 week range which will result in a larger DB hit.

Can I ask the use case for pulling back 7 weeks worth of appointments in one hit, are you performing a data sync or is this for a screen?

I'm currently looking at ways to improve this query to prevent it timing out, this may end up being broken up into another ticket, I'll keep you updated on here.

Thanks

— Reply to this email directly, view it on GitHubhttps://github.com/reapit/foundations/issues/11010#issuecomment-2137701879, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7FSPPNFQ4NNYH4EWJEDS4TZEXYGRAVCNFSM6AAAAABGAUSAL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXG4YDCOBXHE. You are receiving this because you were mentioned.Message ID: @.**@.>> Cybercrime Warning: Please be aware that there is a risk posed by cyber fraud, specifically affecting emails containing bank account details. If you receive an unexpected email from us informing of changes to bank details, please get in touch with your contact immediately to clarify. Note that our bank details WILL NOT change during the course of a transaction. We cannot accept responsibility if you transfer money into an incorrect account. Disclaimer:

This e-mail (and any attachment) is confidential and may also be privileged. It is intended solely for the use of the individual to whom it is addressed. Any views or opinions presented are solely those of the author and do not necessarily represent those of Connells or any of their Subsidiary Companies. Connells accepts no liability for the contents of this e-mail or of any attachment. If you are not the intended recipient, be advised that you have received this e-mail in error and that any use, dissemination, forwarding, disclosure, printing or copying is expressly prohibited. Further, if you are not the intended recipient, you are strictly prohibited from acting or refraining from acting in reliance on this e-mail.

If you have received this mail in error please delete this e-mail and any attachments. If you would prefer not to receive future mailings please email @.*** Please ensure you provide us with ALL email addresses that you would like us to unsubscribe in the event that you have registered with us using more than one address.

The Connells Group describes companies and brands within the Connells Limited group of companies. Connells Limited is registered in England and Wales under company number 3187394. Registered Office is Cumbria House, 16-20 Hockliffe Street, Leighton Buzzard, Bedfordshire, LU7 1GN. VAT Registration Number is 500 2481 05. For activities relating to regulated mortgages and non-investment insurance contracts, Connells Limited is authorised and regulated by the Financial Conduct Authority. Connells Limited’s Financial Services Register number is 302221

Visit http://www.connells.co.uk/legal-notices for details of who we are regulated by.

Visit https://www.connells.co.uk/contact-us for details of how to make a Mortgage Service Complaint.

RWilcox-Reapit commented 4 months ago

Hi @KeithLowe

I've recently put out some performance improvements to the appointments service. After some testing for your use cases above you should notice significant reductions in response time.

Thanks, Ryan

KeithLowe commented 4 months ago

Hi Ryan,

Thanks, much appreciated. If we find any further issue we’ll let you know.

Keith

Keith Lowe | Development Manager | IT Solutions & Development [Connells Group Logo]http://www.connellsgroup.co.uk/ 6 Caldecotte Lake Business Park, Milton Keynes Buckinghamshire, MK7 8JT Tel: 01908 722865<tel:01908%20722865> Email: @.**@.> Web: www.connellsgroup.co.ukhttp://www.connellsgroup.co.uk

From: RWilcox-Reapit @.> Sent: Tuesday, June 4, 2024 3:36 PM To: reapit/foundations @.> Cc: Keith Lowe @.>; Mention @.> Subject: Re: [reapit/foundations] Reapit API's 500 error code (Issue #11010)

WARNING: This message is from outside of the Group, are you sure it is GENUINE? NEVER click on a link or open an attached document unless you are expecting to receive them. NEVER share your login details.

Hi @KeithLowehttps://github.com/KeithLowe

I've recently put out some performance improvements to the appointments service. After some testing for your use cases above you should notice significant reductions in response time.

Thanks, Ryan

— Reply to this email directly, view it on GitHubhttps://github.com/reapit/foundations/issues/11010#issuecomment-2147699995, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7FSPPO5BG4MDFPBQTCPYA3ZFXGDZAVCNFSM6AAAAABGAUSAL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGY4TSOJZGU. You are receiving this because you were mentioned.Message ID: @.**@.>> Cybercrime Warning: Please be aware that there is a risk posed by cyber fraud, specifically affecting emails containing bank account details. If you receive an unexpected email from us informing of changes to bank details, please get in touch with your contact immediately to clarify. Note that our bank details WILL NOT change during the course of a transaction. We cannot accept responsibility if you transfer money into an incorrect account. Disclaimer:

This e-mail (and any attachment) is confidential and may also be privileged. It is intended solely for the use of the individual to whom it is addressed. Any views or opinions presented are solely those of the author and do not necessarily represent those of Connells or any of their Subsidiary Companies. Connells accepts no liability for the contents of this e-mail or of any attachment. If you are not the intended recipient, be advised that you have received this e-mail in error and that any use, dissemination, forwarding, disclosure, printing or copying is expressly prohibited. Further, if you are not the intended recipient, you are strictly prohibited from acting or refraining from acting in reliance on this e-mail.

If you have received this mail in error please delete this e-mail and any attachments. If you would prefer not to receive future mailings please email @.*** Please ensure you provide us with ALL email addresses that you would like us to unsubscribe in the event that you have registered with us using more than one address.

The Connells Group describes companies and brands within the Connells Limited group of companies. Connells Limited is registered in England and Wales under company number 3187394. Registered Office is Cumbria House, 16-20 Hockliffe Street, Leighton Buzzard, Bedfordshire, LU7 1GN. VAT Registration Number is 500 2481 05. For activities relating to regulated mortgages and non-investment insurance contracts, Connells Limited is authorised and regulated by the Financial Conduct Authority. Connells Limited’s Financial Services Register number is 302221

Visit http://www.connells.co.uk/legal-notices for details of who we are regulated by.

Visit https://www.connells.co.uk/contact-us for details of how to make a Mortgage Service Complaint.

github-actions[bot] commented 4 months ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here