reapit / foundations

Foundations platform mono repo
57 stars 21 forks source link

2 APIS failing #11160

Open chestertons opened 4 months ago

chestertons commented 4 months ago

Using the CHT account, we have two API calls which are failing

https://platform.reapit.cloud/companies/?PageNumber=1&PageSize=100&sortBy=modified&modifiedFrom=2024-05-21T09:34:03Z&modifiedTo=2024-05-21T10:51:31Z [message] => Internal server error

https://platform.reapit.cloud/transactions/?PageNumber=1&PageSize=100&sortBy=modified&modifiedFrom=2024-05-16T10:11:04Z&modifiedTo=2024-05-21T08:54:37Z

{ "statusCode": 500, "dateTime": "2024-05-21T07:54:48.132085Z", "description": "An unexpected error has been encountered when fulfilling this request. This incident has been logged and will be investigated. Please try again." }

transactions has been failing since yesterday

These are automated routines collecting data and are crucial to our operation. This type of error is not uncommon.

github-actions[bot] commented 4 months ago

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

plittlewood-rpt commented 4 months ago

Hi @chestertons the transactions API is failing because there are two transactions that have managed to go into your system with no date attached to them. This is the same thing that happened last time . I've raised it internally to see if we can get to the bottom of what's causing it (for reference in case you wish to speak to the branch the transactions are associated to company records UNL11002847 and FCL13000139 - it's probably more appropriate to get the branch to correct the data as I don't have access to your transaction information). I've got a PR up to handle null dates in this field though this shouldn't be required so I'll continue to chase this down internally. I'll let you know once the update goes out

plittlewood-rpt commented 4 months ago

Can you confirm if the issue with the companies API is intermittent or if you're seeing persistent failures here? This one looks to be intermittent from my testing, and is down to the query being executed against the database timing out which is something we'll need to look into. There is some work ongoing specifically to improve performance of requests when using the modified sort/query parameters which I'm hoping will be available soon and should reduce the API latency quite considerably for datasets as large as yours

chestertons commented 4 months ago

Companies API is intermittent

Transactions is 100%

Sent from Outlook for iOShttps://aka.ms/o0ukef


From: Pete Littlewood @.> Sent: Tuesday, May 21, 2024 12:17:18 PM To: reapit/foundations @.> Cc: Dashboard Admin @.>; Mention @.> Subject: Re: [reapit/foundations] 2 APIS failing (Issue #11160)

Can you confirm if the issue with the companies API is intermittent or if you're seeing persistent failures here? This one looks to be intermittent from my testing, and is down to the query being executed against the database timing out which is something we'll need to look into. There is some work ongoing specifically to improve performance of requests when using the modified sort/query parameters which I'm hoping will be available soon and should reduce the API latency quite considerably for datasets as large as yours

— Reply to this email directly, view it on GitHubhttps://github.com/reapit/foundations/issues/11160#issuecomment-2122400552, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC3KZLEJKRNHL64YYCFF7PDZDMUL5AVCNFSM6AAAAABIBJRTB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGQYDANJVGI. You are receiving this because you were mentioned.Message ID: @.***>

The contents of this e-mail do not constitute a commitment by Chestertons, unless separately endorsed by an authorized representative of Chestertons. Chestertons believes that this e-mail and any attachments are free of viruses. However, it is the responsibility of the recipient to ensure it is virus free and Chestertons does not accept any responsibility for any loss or damage that may arise from the use of this e-mail or its contents.

UK offices: Registered office Chesterton UK Services Ltd is 40 Connaught Street, Hyde Park, London, England, W2 2AB Registered in England Company Number 05334580 Chesterton UK Services Ltd - This e-mail is confidential and may contain legally privileged information; it is intended for the use of the addressee only. If you are not the addressee you must not read, use, distribute copy or rely on this e-mail. If you have received this communication in error please notify us immediately by e-mail or by telephone (+44 (0) 20 3040 8240).

plittlewood-rpt commented 4 months ago

HI @chestertons the issue with the transactions API should be resolved. Please note that the data has not been amended but we've put some defensive code in to handle it. A separate item has been logged internally to look at addressing the issue of allowing users to setup transactions with no date entered

plittlewood-rpt commented 4 months ago

Internal ref PBI-5579

chestertons commented 4 months ago

Thanks Pete.

Sent from Outlook for iOShttps://aka.ms/o0ukef


From: Pete Littlewood @.> Sent: Tuesday, May 21, 2024 2:41:07 PM To: reapit/foundations @.> Cc: Dashboard Admin @.>; Mention @.> Subject: Re: [reapit/foundations] 2 APIS failing (Issue #11160)

Internal ref PBI-5579

— Reply to this email directly, view it on GitHubhttps://github.com/reapit/foundations/issues/11160#issuecomment-2122666097, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC3KZLGM2JQEXXNRYI2HPNLZDNFHHAVCNFSM6AAAAABIBJRTB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGY3DMMBZG4. You are receiving this because you were mentioned.Message ID: @.***>

The contents of this e-mail do not constitute a commitment by Chestertons, unless separately endorsed by an authorized representative of Chestertons. Chestertons believes that this e-mail and any attachments are free of viruses. However, it is the responsibility of the recipient to ensure it is virus free and Chestertons does not accept any responsibility for any loss or damage that may arise from the use of this e-mail or its contents.

UK offices: Registered office Chesterton UK Services Ltd is 40 Connaught Street, Hyde Park, London, England, W2 2AB Registered in England Company Number 05334580 Chesterton UK Services Ltd - This e-mail is confidential and may contain legally privileged information; it is intended for the use of the addressee only. If you are not the addressee you must not read, use, distribute copy or rely on this e-mail. If you have received this communication in error please notify us immediately by e-mail or by telephone (+44 (0) 20 3040 8240).