reapit / foundations

Foundations platform mono repo
57 stars 21 forks source link

Record valuation price against the appointment, not property #11161

Open ktanalyst opened 2 months ago

ktanalyst commented 2 months ago

Is your feature request related to a problem? Please describe. I appreciate this is a complex request as it involves changes to the front end software, however there is a significant flaw in the PROPERTY_SALES_VALUATIONS view.

There are three fields within this view which should be pulled from the appointment records, but come from the property record instead:

A valuation price, which can be retrieved from the property_sales_valuations view, should in theory be different for each instance of a valuation. If you run the below query, you will see why this is a problem:

SELECT ID ,PROPERTY_CODE ,VALUATION_DATE ,VALUATION_PRICE ,RECOMMENDED_ASKING_PRICE ,VENDOR_ESTIMATE_PRICE FROM REAPIT.ANALYTICS_KLR.PROPERTY_SALES_VALUATIONS WHERE PROPERTY_CODE = 'WKS200392' ORDER BY VALUATION_DATE

There are four valuation records for this property, each on a different date spanning four years. However, the valuation price for the one in 2020 is the same as the one in 2024. Because this field can only be updated in the financials section on the property card, it is pulling the same value for each appointment record according to the property card. Even more troubling is trying to figure out which valuation instance the price is actually referring to - has it been updated since the last appointment? Has the valuation price changed since the last appointment? These are questions we can't answer in the current format.

Imagine a vendor got a price on a valuation before doing some additional work - the only way to work out the difference in valuation price would be to scroll back through the contact notes or recap emails. We already have the right field to record the information correctly, it's just in the wrong place.

Describe the solution you'd like The ideal solution would be having the VALUATION_PRICE field linked to the appointment record and ultimately added back into the analytics schema via the appointments table. Unless we've missed some logic as to why 'valuation price' sits against a property rather than the valuation appointment itself, the field would serve a much better purpose being moved to a more appropriate location where it can be completed for each valuation. This would also be required for the two other fields as described earlier.

Describe alternatives you've considered There isn't another way to get the valuation price for each valuation appointment without pulling the single reference point from the financials section of the property card.

github-actions[bot] commented 2 months ago

Thank you for raising a feature request. Feature requests will be prioritised in accordance with our roadmap, customer and developer priorities. This request will be reviewed in our weekly refinement sessions and assigned to a specific project board or column, depending on the nature of the request and the development work required. For more information on our processes, please click here

plittlewood-rpt commented 1 month ago

Hi @ktanalyst you're right that this would need a change to the core product to achieve. I'll flag this item with our internal product team and post the reference back here

plittlewood-rpt commented 1 month ago

Internal Reference PBI-5609

github-actions[bot] commented 1 month ago

As this issue relates to AgencyCloud, we are unable to process this through the Platform in accordance with our Developer Processes. Issues relating to AgencyCloud should not be submitted via the Foundations GitHub repo but should be raised via the Reapit Service Desk by a Reapit Customer. Please ask a Reapit Customer to raise this issue via the Reapit Service Desk. For more information on our processes, please click here