External offers are not returned from conveyancing API when office groups in use

[hoangnguyentci]

Describe the bug:

• Reapit API response with message "Entity Offer (FAR240136) was not found"
• When we called API https:/platform.reapit.cloud/conveyancing/FAR240135, it returned: “id”: “FAR240135", “isExternal”: false, “propertyId”: “FAR240076”, “externalAgent”: null, “externalAgentId”: null, “upwardChainId”: null, “downwardChainId”: “FAR240136",
• From the downwardChainId, we can't find conveyancing FAR240136

To Reproduce Steps to reproduce the behaviour:

• Call API: https:/platform.reapit.cloud/conveyancing/FAR240136

  “statusCode”: 404, “dateTime”: “2024-07-01T08:38:07.2325147Z”, “description”: “Entity \“Offer\” (FAR240136) was not found.”

Expected behaviour

• This API return json array of conveyancing object

Additional context

• Customer agent_name":"Romans" and client_code:"ROM-GRMN"

Specification

• Project: Reapit.Services.Conveyancing
• When office groups are in use, external offers cannot be returned because the security applied is based on the attached property. External offers do not have a property in the system. We need to update this service to handle a null join so that external offers do get returned. We still need to consider security here however, so we may need to join the offers that do have properties attached to their upward/downward chains in someway. In the example above, FAR240136 is an external offer and as such has no attached property to ascertain the office ownership of the offer from. The only way to get this is to join from the original offer then back to the property
• A quick route would be to always return external offers when office groups are being used, though we'd need to consider this carefully with the product team

[github-actions[bot]]

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

[AshDeeming]

Migrated: PBI-5850