reapit / foundations

Foundations platform mono repo
57 stars 22 forks source link

brochure issue #5700

Closed Z3nAg3ncy closed 2 years ago

Z3nAg3ncy commented 2 years ago

brochure is not showing on berryknowe as the feed is not supplying the information

github-actions[bot] commented 2 years ago

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

plittlewood-rpt commented 2 years ago

Hi @Z3nAg3ncy - to allow us to investigate your problem, please complete all the information requested when using the Bug ticket template. This appears to be a duplicate of #5701 which I will close

github-actions[bot] commented 2 years ago

We have recently requested additional information relating to the issue you have raised. Please can you take the time to review this ticket and where applicable, provide the information requested. For more information on our processes, please click here

Z3nAg3ncy commented 2 years ago

brochure not in feed image (9) (003)

plittlewood-rpt commented 2 years ago

@Z3nAg3ncy that suggests you're trying to request a field you don't have permission to view. What request are you making?

Z3nAg3ncy commented 2 years ago

why was it working and now its not

plittlewood-rpt commented 2 years ago

Hi @Z3nAg3ncy it looks like this may be occurring following some configuration changes made this morning by our infrastructure team. I'm just confirming with them what changes have been made (and why). Can you confirm the GET request you are trying to make (specifically the extrasField parameters) and I can arrange to get this corrected as a priority

plittlewood-rpt commented 2 years ago

The issue above was actually resolved by our infrastructure team this morning at around 9.50am. If it is still outstanding please advise and provide comprehensive information about the problem you are currently experiencing

Z3nAg3ncy commented 2 years ago

nope it still is not pulling the brochure through https://bellingram.co.uk/agency/for-sale/berryknowe-hatchbank-road-kinross-ky13-0lf/ we have provided the details to you concerning this

plittlewood-rpt commented 2 years ago

The only detail you've given me so far is a link. We do not manage the Bell Ingram website so I'm afraid unless you give me information about what fields you're expecting to be populated that aren't I can't really provide any useful assistance

plittlewood-rpt commented 2 years ago

I have run a request for the property in question and the brochure details are coming back in the response with no issues. There are various ways you can access the brochure, but the simplest is to following the sellingBrochure link in the _links collection eg

 "_links": {
        "self": {
            "href": "/properties/PER210083"
        },
        "images": {
            "href": "/propertyImages/?propertyId=PER210083"
        },
        "documents": {
            "href": "/documents/?associatedType=property&associatedId=PER210083"
        },
        "offers": {
            "href": "/offers/?propertyId=PER210083"
        },
        "appointments": {
            "href": "/appointments/?propertyId=PER210083"
        },
        "negotiator": {
            "href": "/negotiators/CSW"
        },
        "offices": {
            "href": "/offices/?id=PER"
        },
        "department": {
            "href": "/departments/G"
        },
        "vendor": {
            "href": "/vendors/PER210083"
        },
        "area": {
            "href": "/areas/pak"
        },
        "sellingBrochure": {
            "href": "/documents/PER21000487"
        },
        "sellingAgency": {
            "href": "/configuration/agencyTypes/SA"
        }

I note on the property in question that it's been associated to the property as a "Letter" so if you're checking the typeId in the response from the documents API and are expecting DET this would explain why it's not displaying. That's down to the end user to make sure it's set correctly though. Users can set any document as the brochure on a property, so it won't always necessarily have a typeId of DET

Z3nAg3ncy commented 2 years ago

Can you explain why this works in all the other properties and in the past but does not in this individual property?

From: Pete Littlewood @.> Sent: 15 December 2021 14:20 To: reapit/foundations @.> Cc: Z3nAg3ncy @.>; Mention @.> Subject: Re: [reapit/foundations] brochure issue (Issue #5700)

I have run a request for the property in question and the brochure details are coming back in the response with no issues. There are various ways you can access the brochure, but the simplest is to following the sellingBrochure link in the _links collection eg

"_links": { "self": { "href": "/properties/PER210083" }, "images": { "href": "/propertyImages/?propertyId=PER210083" }, "documents": { "href": "/documents/?associatedType=property&associatedId=PER210083" }, "offers": { "href": "/offers/?propertyId=PER210083" }, "appointments": { "href": "/appointments/?propertyId=PER210083" }, "negotiator": { "href": "/negotiators/CSW" }, "offices": { "href": "/offices/?id=PER" }, "department": { "href": "/departments/G" }, "vendor": { "href": "/vendors/PER210083" }, "area": { "href": "/areas/pak" }, "sellingBrochure": { "href": "/documents/PER21000487" }, "sellingAgency": { "href": "/configuration/agencyTypes/SA" }

I note on the property in question that it's been associated to the property as a "Letter" so if you're checking the typeId in the response from the documents API and are expecting DET this would explain why it's not displaying. That's down to the end user to make sure it's set correctly though. Users can set any document as the brochure on a property, so it won't always necessarily have a typeId of DET

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reapit/foundations/issues/5700#issuecomment-994835393 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHBK2IT4RMIMQIQI3FEQYLURCPZPANCNFSM5KDKMF7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . https://github.com/notifications/beacon/AHHBK2OUHTVLGTJIEPH4QOTURCPZPA5CNFSM5KDKMF72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHNF7XQI.gif

plittlewood-rpt commented 2 years ago

I'd need to know how you were processing the data to be able to provide an opinion on that. The documents API doesn't do anything special when it comes to surfacing the data the customer has entered into the system. It could be that the document was added differently.

Z3nAg3ncy commented 2 years ago

what you have suggested "the simplest is to following the sellingBrochure link in the _links collection" is what I'm doing, but I get a server error when I try to actually download the brochure

this is the request I'm making, and it's returning the error in the attached screenshot

curl --location --request GET 'https://platform.reapit.cloud/documents/PER21000487/download' \

--header 'Accept: application/octet-stream' \

--header 'api-version: 2020-01-31' \

--header 'reapit-customer: BEL' \

--header 'Authorization: Bearer [access_token]'

Generates this

all the other property brochures are working, it's just this one

From: Pete Littlewood @.> Sent: 15 December 2021 14:30 To: reapit/foundations @.> Cc: Z3nAg3ncy @.>; Mention @.> Subject: Re: [reapit/foundations] brochure issue (Issue #5700)

I'd need to know how you were processing the data to be able to provide an opinion on that. The documents API doesn't do anything special when it comes to surfacing the data the customer has entered into the system. It could be that the document was added differently.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reapit/foundations/issues/5700#issuecomment-994844853 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHBK2MD2ESMOBRANNUZECLURCRADANCNFSM5KDKMF7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . https://github.com/notifications/beacon/AHHBK2IDSXYKO5IZ5TKMVRDURCRADA5CNFSM5KDKMF72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHNGCBNI.gif

Z3nAg3ncy commented 2 years ago

image (12)

plittlewood-rpt commented 2 years ago

Ok thanks - that's the kind of information I need. I suspect this is down to the brochure size and the file transfer internally on the platform taking too long which results in the request timing out. Let me see how big that file is.

Z3nAg3ncy commented 2 years ago

Ok thanksAlanAlan RonaldManaging DirectorThe Zen Agency0797381472901412291333 -------- Original message --------From: Pete Littlewood @.> Date: 15/12/2021 16:54 (GMT+00:00) To: reapit/foundations @.> Cc: Z3nAg3ncy @.>, Mention @.> Subject: Re: [reapit/foundations] brochure issue (Issue #5700) Ok thanks - that's the kind of information I need. I suspect this is down to the brochure size and the file transfer internally on the platform taking too long which results in the request timing out. Let me see how big that file is.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

JoWiseman commented 2 years ago

Thank you for this information, Moira has just readded a smaller version of the brochure to Reapit and hopefully this will now work.

Johanna Wiseman MARLA Sales & Lettings Negotiator

Bell Ingram LLP, Durn, Isla Road, Perth, PH2 7HF T: 01738 621121 bellingram.co.ukhttp://www.bellingram.co.uk/

Please note my working days are Monday to Thursday

Scottish Letting Agent Register Number: LARN1902043

Follow us on twitterhttp://twitter.com/#!/BellIngram like us on facebookhttp://www.facebook.com/#!/bellingram visit our websitehttp://www.bellingram.co.uk/ or follow our bloghttps://www.bellingram.co.uk/latest-news/blog/ View our latest properties for salehttps://www.bellingram.co.uk/estate-agency/for-sale/?filter_4813=4818&transactionType=6495&filter_14930=&filter_14931=&filter_4826=&filter_6505=&filter_21453=

@.***http://www.bellingram.co.uk/ This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed and should not be disclosed to any other party. If you have received this email in error please notify your system manager and the sender of this message. Bell Ingram do not accept any liability for viruses. Please ensure you have adequate virus protection before you open or detach any documents from this transmission. P Please consider the environment before printing this e-mail

From: Pete Littlewood @.> Sent: 15 December 2021 16:55 To: reapit/foundations @.> Cc: Subscribed @.***> Subject: Re: [reapit/foundations] brochure issue (Issue #5700)

Ok thanks - that's the kind of information I need. I suspect this is down to the brochure size and the file transfer internally on the platform taking too long which results in the request timing out. Let me see how big that file is.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/reapit/foundations/issues/5700#issuecomment-994978073, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AW55KMP42P4MQ5ZQYOGAOITURDB5FANCNFSM5KDKMF7Q. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

plittlewood-rpt commented 2 years ago

Thanks - I can see the filesize is now much smaller so please report back as appropriate. I will log a separate ticket for looking at managing large file downloads.

plittlewood-rpt commented 2 years ago

I can now see the brochure on the listing so will close this ticket. I will link the new ticket back to this one for reference.

github-actions[bot] commented 2 years ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here

Z3nAg3ncy commented 2 years ago

Thanks Pete

I see that too

Alan

From: Pete Littlewood @.> Sent: 16 December 2021 08:00 To: reapit/foundations @.> Cc: Z3nAg3ncy @.>; Mention @.> Subject: Re: [reapit/foundations] brochure issue (Issue #5700)

I can now see the brochure on the listing so will close this ticket. I will link the new ticket back to this one for reference.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reapit/foundations/issues/5700#issuecomment-995528825 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHBK2LGVQMN27NBCTDSGF3URGMAXANCNFSM5KDKMF7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . https://github.com/notifications/beacon/AHHBK2OS4Q5H47JY5TJCM53URGMAXA5CNFSM5KDKMF72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHNLJA6I.gif

github-actions[bot] commented 2 years ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here