reapit / foundations

Foundations platform mono repo
57 stars 21 forks source link

Timeout calling the appointments endpoint #6176

Open s-finny opened 2 years ago

s-finny commented 2 years ago

Describe the bug We are calling the appointments endpoint as follows and always get a timeout on the first call.

To Reproduce Endpoint: https://platform.reapit.cloud/appointments/?reapit-customer=BEF

Payload: {"officeId":"BIS","marketingMode":"selling","pageSize":100,"modifiedFrom":"2022-02-15T13:25:39.0000000Z","start":"2021-01-01T00:00:00.0000000Z","typeId":["VL","PG","PL","IA"]}

Response: {"message": "Endpoint request timed out"}

This is returned after 30 seconds, we retry 60 seconds later and get the results.

Expected behaviour As we are calling this with a modifiedFrom and limiting the typeId we would expect this endpoint to return a small number of results and quite quickly.

Expected result as below, but this still took 18 seconds to respond with nothing.

{ "_embedded": [], "pageNumber": 1, "pageSize": 100, "pageCount": 0, "totalPageCount": 0, "totalCount": 0, "_links": { "self": { "href": "/appointments/?PageNumber=1&PageSize=100&marketingMode=selling&modifiedFrom=2022-02-15T13:25:39.0000000Z&officeId=BIS&reapit-customer=BEF&start=2021-01-01T00:00:00.0000000Z&typeId=IA&typeId=VL&typeId=PG&typeId=PL" }, "first": { "href": "/appointments/?PageNumber=1&PageSize=100&marketingMode=selling&modifiedFrom=2022-02-15T13:25:39.0000000Z&officeId=BIS&reapit-customer=BEF&start=2021-01-01T00:00:00.0000000Z&typeId=IA&typeId=VL&typeId=PG&typeId=PL" } } }

Specification

github-actions[bot] commented 2 years ago

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

plittlewood-rpt commented 2 years ago

Hi @s-finny - thanks for reaching out. Your request looks a little odd as the reapit-customer value should be a header not a query string parameter. In any case, we are already aware of an issue with large databases and specifically using the modifiedFrom parameter and it is something we have done some work to resolve already in #5931 however there is some work that needs to be undertaken by our infrastructure team on the database itself before it can be deployed. I will chase our infrastructure team to see where we are it with it and add BEF to the list

plittlewood-rpt commented 2 years ago

Waiting on infrastructure

david-silverink commented 2 years ago

@plittlewood-rpt Receiving a large amount of timeouts today, just to note also.

plittlewood-rpt commented 2 years ago

Have chased for update from infrastructure this morning

HollyJoyPhillips commented 2 years ago

We've made another request for an update from infrastructure.

HollyJoyPhillips commented 2 years ago

FYI, we've requested an update from infrastructure. Will update when possible.

HollyJoyPhillips commented 2 years ago

HP to speak with Abdul

plittlewood-rpt commented 2 years ago

HP to speak to Abdul

plittlewood-rpt commented 1 year ago

This change went into 12.149 which BEF are still not running so we cannot move on this yet. Will speak to internal upgrade team to see where this is at and why it is taking so long

plittlewood-rpt commented 1 year ago

@1718066-jpoolton is that any movement on the upgrade for this customer yet?

plittlewood-rpt commented 1 year ago

@1718066-jpoolton are we any closer to getting this customer upgraded yet?

1718066-jpoolton commented 1 year ago

Nope, it’s still with Shaz, he was following this up to chase them as had a working UAT for some time. But nothing booked yet.

Sent from Outlook for iOShttps://aka.ms/o0ukef


From: Pete Littlewood @.> Sent: Tuesday, June 27, 2023 11:07:20 AM To: reapit/foundations @.> Cc: John Poolton @.>; Mention @.> Subject: [EXTERNAL] Re: [reapit/foundations] Timeout calling the appointments endpoint (Issue #6176)

https://github.com/1718066-jpoolton

External Message - Please be cautious when opening links or attachments in email


@1718066-jpoolton are we any closer to getting this customer upgraded yet?

— Reply to this email directly, view it on GitHubhttps://github.com/reapit/foundations/issues/6176#issuecomment-1609197676, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF2SB73MOGS7QKB2DK5SKZDXNKWFLANCNFSM5ORBNNUA. You are receiving this because you were mentioned.Message ID: @.***>

plittlewood-rpt commented 1 year ago

Customer upgrade is now in the pipeline, after which we can enable the feature flag that will alter the behaviour for this customer

plittlewood-rpt commented 10 months ago

Customer has now been upgraded so we can look at altering the Platform configuration. We will need to ensure all rows in the diary table have an amend date. This should be done with webhooks disabled as there are about half a million rows without the info

github-actions[bot] commented 10 months ago

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here

HollyJoyPhillips commented 6 months ago

Waiting for version updates across all DB's from infra. Once confirmed will raise an internal ticket to back date the data.