reapit / foundations

Foundations platform mono repo
57 stars 21 forks source link

In pagination links the embed=images parameter is missing #6546

Closed rajeshwl closed 2 years ago

rajeshwl commented 2 years ago

Describe the bug We are trying to import properties for our client using pagination limit 25, also we have used the embed option to get images and negotiator data. For the first page we are receiving property with images and negotiator embeded. And in the links the next pages url has been formed without the images embed argument.

Sample request: Actual import request: /properties/?marketingMode=selling&internetAdvertising=true&sellingStatus=forSale&sellingStatus=underOffer&sellingStatus=exchanged&sellingStatus=completed&embed=images&embed=negotiator Pagination links we received in _links: /properties/?PageNumber=2&PageSize=25&embed=negotiator&internetAdvertising=true&marketingMode=selling&sellingStatus=completed&sellingStatus=forSale&sellingStatus=underOffer&sellingStatus=exchanged

Seems when we are requesting multiple embed the latest one has been overridden. The embed values are not considered as array it seems.

Specification

github-actions[bot] commented 2 years ago

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

github-actions[bot] commented 2 years ago

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 1 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here