search

reapit / foundations

Foundations platform mono repo
57 stars 22 forks source link

Transpose legacy REST API endpoints #6935

Closed jazzlall closed 2 years ago

jazzlall commented 2 years ago

Not sure if this has already been requested by Sapphira as I can't find anything. We have the following endpoints in the legacy REST API that need to be available in Platform

GET /negotiators/{ID}/availability GET /negotiators/{ID}/appointments GET /valuationAppointments GET /viewingAppointments GET /availability DELETE /appointments/{ID}

The context for this is for the new version of the Booking a Valuation/Viewing functionality (previously known as RDA) that the AP will be building and cannot against the legacy API's

github-actions[bot] commented 2 years ago

Thank you for raising a feature request. Feature requests will be prioritised in accordance with our roadmap, customer and developer priorities. This request will be reviewed in our weekly refinement sessions and assigned to a specific project board or column, depending on the nature of the request and the development work required. For more information on our processes, please click here

HollyJoyPhillips commented 2 years ago

Hi Jazz,

With regards to the following:

GET /negotiators/{ID}/appointments GET /valuationAppointments GET /viewingAppointments DELETE /appointments/{ID}

The APPOINTMENTS endpoint already allows for searching by type and by negotiator. Appointment types are customisable, so we provide a configuration endpoint GET /configuration/appointmentTypes

You can cancel appointments but not delete. This is by design for audit trails etc and we won’t be able to add a delete endpoint.

With regards to following (availability):

GET /negotiators/{ID}/availability GET /availability

To provide availability, we would have to add quite a lot of business logic and user specific configuration on the Platform. The Platform was not designed in this way and not something we would want to do.

However, we did look into this early last year and the way to do this would be for AP to write the logic in the app/integration. For example, they could obtain all appointments for a specific negotiator/office and then surface in the app, the available time slots. This is available to do now.

jazzlall commented 2 years ago

Thanks @HollyJoyPhillips , based on your feedback I'm happy to close this.

github-actions[bot] commented 2 years ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here