reapit / foundations

Foundations platform mono repo
57 stars 22 forks source link

Ed Dempsey's BER Details for MyHome.ie #7168

Closed MatthewGoddard closed 2 years ago

MatthewGoddard commented 2 years ago

Request

In order for us to grant access to Semi-structured 'extras' field data, please provide the following information in this request:

colearymyhome commented 2 years ago

If possible, could this be made available on the webhook as well as the API please?

MatthewGoddard commented 2 years ago

@colearymyhome This is for the API only.

plittlewood-rpt commented 2 years ago

Hi @MatthewGoddard this will be added as per #7017 where webhooks will also benefit.

github-actions[bot] commented 2 years ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here

gnthackray-reapit commented 2 years ago

Looked at whitelist in AWS(see below). It already contains the extras fields.

"extrasWhitelist": "properties.pBERExempt,properties.pBERRating,properties.pBERNumber,properties.pEPI,properties.pFeatured"}

plittlewood-rpt commented 2 years ago

@MatthewGoddard as above this is already configured. MyHome just need to use the ?extrasField query string parameter to get it back from the API for this customer.

ie: GET /properties?extrasField=pBERRating&extrasField=pBERExempt&extrasField=pBERNumber&extrasField=pEPI

The same parameter is available on the GET /properties/{id} endpoint.

Any issues let me know Thanks

github-actions[bot] commented 2 years ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here

MatthewGoddard commented 2 years ago

Thanks @plittlewood-rpt, very much appreciated. As always.

github-actions[bot] commented 2 years ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here

plittlewood-rpt commented 2 years ago

For info the update to include this information in the core property model has now hit production so you should start getting this information back in webhooks for properties in Ireland.

github-actions[bot] commented 2 years ago

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here