Missing appointments when retrieving negotiator appointments

[r-wilson-ire]

Describe the bug We call the /appointments/ endpoint to retrieve appointments for a negotiator The returned appointments do not match those visible in the negotiator's Reapit diary - it appears that recurring appointments are not being returned

To Reproduce Steps to reproduce the behaviour

1. Negotiator had three appointments in their Reapit diary for 1st July: 8:00 AM recurring appointment, 9:00 AM recurring appointment, and 1:00 PM non-recurring appointment

2. On the API, when performing a GET call to /appointments/ endpoint, for that negotiator for appointments that start on 1st July and end before 2nd July, only 1:00 PM appointment was returned from the API call

Expected behaviour All appointments that appear in the negotiators diary for 1st July, would be returned on the GET /appointments/ call for that time period

Screenshots

Specification

• Project: Reapit.Services.Appointments
• Look at what mechanism used to do and assess performance (this is commented out in AppointmentRepository and previously made use of some unreferenced methods in that class also (ie SortAndPageResultsAsync). We need to do a stringent performance analysis here as there'll likely need to be a refactor so we can fetch the appointments in one query with no joins, and then get the related data separately.
• Outcome of this ticket is to update this service to return the original appointment and NOT duplicated copies of the appointment

[github-actions[bot]]

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

[github-actions[bot]]

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 1 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion. For more information on our processes, please click here

[RWilcox-Reapit]

Hi @r-wilson-ire

I have update the endpoint to now display recurring appointments that fall within a specified start and end date.

There are however a few requirements for these to be display which is documented on the endpoint as: Recurring appointments can also be retrieved by specifying a start and end date along with any of the following query parameters: Id, NegotiatorId, PropertyId, AttendeeId

[github-actions[bot]]

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference. For more information on our processes, please click here